[clang] [clang-cl] Map /Ot to -O3 instead of -O2 (PR #95406)

2024-06-14 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: For reference, current MSVC has a flag /Ob3 to request more aggressive inlining. https://github.com/llvm/llvm-project/pull/95406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-cl] Map /Ot to -O3 instead of -O2 (PR #95406)

2024-06-14 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: If we're trying to match MSVC, the amount of inlining MSVC does at /O2 is probably closer to what clang does at -O2 than -O3. Which is why it was mapped that way in 015ce0f68f791b3abec4225c1b2e532ce5020174, I think. clang's -O3 is really aggressive (which tends to look

[clang] [clang-cl] Map /Ot to -O3 instead of -O2 (PR #95406)

2024-06-14 Thread via cfe-commits
https://github.com/zmodem closed https://github.com/llvm/llvm-project/pull/95406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Map /Ot to -O3 instead of -O2 (PR #95406)

2024-06-13 Thread Nico Weber via cfe-commits
https://github.com/nico approved this pull request. https://github.com/llvm/llvm-project/pull/95406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Map /Ot to -O3 instead of -O2 (PR #95406)

2024-06-13 Thread Nico Weber via cfe-commits
nico wrote: Oh, you have that in the release notes already, even better. https://github.com/llvm/llvm-project/pull/95406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Map /Ot to -O3 instead of -O2 (PR #95406)

2024-06-13 Thread Nico Weber via cfe-commits
nico wrote: Can you add something like "use /O2 /clang:-O2 to restore the previous behavior" to the commit message, on case someone prefers that? Otherwise LG. https://github.com/llvm/llvm-project/pull/95406 ___ cfe-commits mailing list

[clang] [clang-cl] Map /Ot to -O3 instead of -O2 (PR #95406)

2024-06-13 Thread via cfe-commits
zmodem wrote: @AaronBallman as discussed on https://discourse.llvm.org/t/clang-cl-optimization-option/79554 Also @nico who IIRC looked at these flags in recent times. https://github.com/llvm/llvm-project/pull/95406 ___ cfe-commits mailing list

[clang] [clang-cl] Map /Ot to -O3 instead of -O2 (PR #95406)

2024-06-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Hans (zmodem) Changes /Ot (which is also implied by /O2) is supposed to optimize for maximum speed, so -O3 seems like a better match. --- Full diff: https://github.com/llvm/llvm-project/pull/95406.diff

[clang] [clang-cl] Map /Ot to -O3 instead of -O2 (PR #95406)

2024-06-13 Thread via cfe-commits
https://github.com/zmodem created https://github.com/llvm/llvm-project/pull/95406 /Ot (which is also implied by /O2) is supposed to optimize for maximum speed, so -O3 seems like a better match. >From 90e7c202bd55fce943b77fd926f5fc4c5835dc3f Mon Sep 17 00:00:00 2001 From: Hans Wennborg Date: