[clang] [clang-format] Add common attribute macros to Google style (PR #76239)

ilya-biryukov wrote: This change did not aim to change the behavior, it's quite the opposite, I tried to guide `clang-format` parsing to recognize attribute and format the code in the way we always intended it to. If there is a way to do that without adding the macro names to the

[clang] [clang-format] Add common attribute macros to Google style (PR #76239)

HazardyKnusperkeks wrote: > Who should have the final say on the Google code style if not Google? That's also my point of view. Who ever decides to use google style, has to live with google changing its style. https://github.com/llvm/llvm-project/pull/76239

[clang] [clang-format] Add common attribute macros to Google style (PR #76239)

rymiel wrote: Who should have the final say on the Google code style if not Google? https://github.com/llvm/llvm-project/pull/76239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add common attribute macros to Google style (PR #76239)

owenca wrote: > `GUARDED_BY` and `ABSL_GUARDED_BY` are very commoon in Google codebases so it > is reasonable to include them by default to avoid the need for extra > configuration in every Google repository. I don't feel comfortable with this as it might impact users of the Google style

[clang] [clang-format] Add common attribute macros to Google style (PR #76239)

https://github.com/ilya-biryukov closed https://github.com/llvm/llvm-project/pull/76239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add common attribute macros to Google style (PR #76239)

https://github.com/krasimirgg approved this pull request. thank you! https://github.com/llvm/llvm-project/pull/76239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add common attribute macros to Google style (PR #76239)

llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Ilya Biryukov (ilya-biryukov) Changes We have found that 199fc973ced20016b04ba540cf63a1d4914fa513 regresses formatting of our codebases because we do not properly configure the names of attribute macros. `GUARDED_BY` and

[clang] [clang-format] Add common attribute macros to Google style (PR #76239)

https://github.com/ilya-biryukov created https://github.com/llvm/llvm-project/pull/76239 We have found that 199fc973ced20016b04ba540cf63a1d4914fa513 regresses formatting of our codebases because we do not properly configure the names of attribute macros. `GUARDED_BY` and `ABSL_GUARDED_BY`