[clang] [clang-format] Don't always break before << between string literals (PR #92214)

mydeveloperday wrote: I agree On Sat, 1 Jun 2024 at 04:12, Owen Pan ***@***.***> wrote: > We should backport it to 18.1.7 IMO. See #93034 > and #93958 > . WDYT @mydeveloperday >

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

owenca wrote: We should backport it to 18.1.7 IMO. See #93034 and #93958. WDYT @mydeveloperday @HazardyKnusperkeks? https://github.com/llvm/llvm-project/pull/92214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

llvmbot wrote: Failed to cherry-pick: 8fe39e64c0ef0a1aefce3c1187c5822343caeedd https://github.com/llvm/llvm-project/actions/runs/9321579020 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

owenca wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/8fe39e64c0ef0a1aefce3c1187c5822343caeedd https://github.com/llvm/llvm-project/pull/92214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/92214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

@@ -10539,6 +10539,17 @@ TEST_F(FormatTest, KeepStringLabelValuePairsOnALine) { " bbb);"); } +TEST_F(FormatTest, WrapBeforeInsertionOperatorbetweenStringLiterals) { + verifyFormat("QStringList() << \"foo\" << \"bar\";");

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

@@ -10539,6 +10539,17 @@ TEST_F(FormatTest, KeepStringLabelValuePairsOnALine) { " bbb);"); } +TEST_F(FormatTest, WrapBeforeInsertionOperatorbetweenStringLiterals) { + verifyFormat("QStringList() << \"foo\" << \"bar\";");

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/92214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

owenca wrote: > This is interesting.. I like it in that its a "Leave" ... but part of me > would like this choice of default behind an option. As with the previous > changes in this area I'm uncomfortable about us changing how it behaves, but > would like the extra capability to choose.. I'm

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

https://github.com/HazardyKnusperkeks approved this pull request. I think this is a reasonable compromise. https://github.com/llvm/llvm-project/pull/92214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

https://github.com/mydeveloperday approved this pull request. This is interesting.. I like it in that its a "Leave" ... but part of me would like this choice of default behind an option. As with the previous changes in this area I'm uncomfortable about us changing how it behaves, but would

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

owenca wrote: See also the discussion in https://reviews.llvm.org/D80950. https://github.com/llvm/llvm-project/pull/92214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Instead, leave the line wrapping as is. Fixes #43887. Fixes #44363. --- Full diff: https://github.com/llvm/llvm-project/pull/92214.diff 2 Files Affected: - (modified)

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/92214 Instead, leave the line wrapping as is. Fixes #43887. Fixes #44363. >From 40eeb958cef55465fdcee66ab385928c1f202e50 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 14 May 2024 19:14:15 -0700 Subject: [PATCH]