[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-26 Thread via cfe-commits
mydeveloperday wrote: > Isn't fixing bugs meant to change defaults? See #61732, #48746 and #93793. > The old version is confusing since it looks like a separate template > parameter when it isn't. I'm ok, if the second style is what we want if thats what we are expecting then I'm good with

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-24 Thread Emilia Kond via cfe-commits
rymiel wrote: Isn't fixing bugs meant to change defaults? See #61732, #48746 and #93793. The old version is confusing since it looks like a separate template parameter when it isn't. https://github.com/llvm/llvm-project/pull/96396 ___ cfe-commits

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-24 Thread via cfe-commits
https://github.com/mydeveloperday commented: Doesn't this show a change in default formatting from ```c++ template class QQQ> class PPP> void comment_to_html_conversion_22() ``` ```c++ template class QQQ> class PPP> void comment_to_html_conversion_22() ``` I think the fact that the

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-22 Thread Emilia Kond via cfe-commits
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/96396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-22 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/96396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Emilia Kond (rymiel) Changes Reapply 4a7bf42a9b83144db8a11ac06cce4da21166e6a2 which was reverted in 34d44eb41dfbbbf01712719558b02763334fbeb3 Not sure why there are tests elsewhere in clang that rely on the output of clang-format, but

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-22 Thread Emilia Kond via cfe-commits
https://github.com/rymiel created https://github.com/llvm/llvm-project/pull/96396 Reapply 4a7bf42a9b83144db8a11ac06cce4da21166e6a2 which was reverted in 34d44eb41dfbbbf01712719558b02763334fbeb3 Not sure why there are tests elsewhere in clang that rely on the output of clang-format, but they