https://github.com/mydeveloperday closed
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mydeveloperday wrote:
"closed due to inactivity"
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
> Can we have a rule that a PR that reaches 6 months or 1 year without activity
> we close with a comment of "
Yep. IMO six months of no response _from the author_ is sufficient to close the
PR. However, if we can't find a reviewer for the PR (e.g. #78904), we should
leave it op
mydeveloperday wrote:
...of comment of "closed due to inactivity" or something like that?
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Devansh Varshney (देवांश वार्ष्णेय) (varshneydevansh)
Changes
## The basics
- [x] I branched from the main
- [x] My pull request is against main
https://github.com/mydeveloperday reopened
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday closed
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mydeveloperday wrote:
Can we have a rule that a PR that reaches 6 months or 1 year without activity
we close with a comment of "
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
https://github.com/mydeveloperday unresolved
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/varshneydevansh resolved
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/varshneydevansh resolved
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/varshneydevansh resolved
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1199,6 +1199,15 @@ template <> struct
DocumentListTraits> {
return Seq[Index];
}
};
+
+template <> struct ScalarEnumerationTraits {
+ static void enumeration(IO &IO, FormatStyle::GotoLabelIndentation &Value) {
+IO.enumCase(Value, "None", FormatStyle::GLI_None);
https://github.com/mydeveloperday requested changes to this pull request.
I’m not sure I quite understand what you are trying to do here now
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
https://github.com/mydeveloperday edited
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday edited
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -161,7 +171,8 @@ TEST(ConfigParseTest, ParsesConfigurationBools) {
CHECK_PARSE_BOOL(IndentAccessModifiers);
CHECK_PARSE_BOOL(IndentCaseLabels);
CHECK_PARSE_BOOL(IndentCaseBlocks);
- CHECK_PARSE_BOOL(IndentGotoLabels);
+ CHECK_PARSE_ENUM(IndentGotoLabels,
@@ -2421,20 +2421,28 @@ struct FormatStyle {
/// Indent goto labels.
///
- /// When ``false``, goto labels are flushed left.
/// \code
- ///true: false:
- ///int f() { vs. int f() {
- /// if (foo
@@ -3311,22 +3311,22 @@ the configuration (without a prefix: ``Auto``).
.. _IndentGotoLabels:
-**IndentGotoLabels** (``Boolean``) :versionbadge:`clang-format 10` :ref:`¶
`
+**IndentGotoLabels** (``enum``) :versionbadge:`clang-format 10` :ref:`¶
`
Indent goto labels.
-
varshneydevansh wrote:
> Do you actually want to use that feature, or do you only want to work on
> something?
>
As it's something of my past pending task, I'm looking to learn and contribute
in any way I can. I left without even trying to contribute to open source
codes. =)
https://gith
@@ -2421,20 +2421,28 @@ struct FormatStyle {
/// Indent goto labels.
///
- /// When ``false``, goto labels are flushed left.
/// \code
- ///true: false:
- ///int f() { vs. int f() {
- /// if (foo
@@ -161,7 +171,8 @@ TEST(ConfigParseTest, ParsesConfigurationBools) {
CHECK_PARSE_BOOL(IndentAccessModifiers);
CHECK_PARSE_BOOL(IndentCaseLabels);
CHECK_PARSE_BOOL(IndentCaseBlocks);
- CHECK_PARSE_BOOL(IndentGotoLabels);
+ CHECK_PARSE_ENUM(IndentGotoLabels,
@@ -3311,22 +3311,22 @@ the configuration (without a prefix: ``Auto``).
.. _IndentGotoLabels:
-**IndentGotoLabels** (``Boolean``) :versionbadge:`clang-format 10` :ref:`¶
`
+**IndentGotoLabels** (``enum``) :versionbadge:`clang-format 10` :ref:`¶
`
Indent goto labels.
-
@@ -3311,22 +3311,22 @@ the configuration (without a prefix: ``Auto``).
.. _IndentGotoLabels:
-**IndentGotoLabels** (``Boolean``) :versionbadge:`clang-format 10` :ref:`¶
`
+**IndentGotoLabels** (``enum``) :versionbadge:`clang-format 10` :ref:`¶
`
Indent goto labels.
-
@@ -2421,20 +2421,28 @@ struct FormatStyle {
/// Indent goto labels.
///
- /// When ``false``, goto labels are flushed left.
/// \code
- ///true: false:
- ///int f() { vs. int f() {
- /// if (foo
https://github.com/HazardyKnusperkeks edited
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -161,7 +171,8 @@ TEST(ConfigParseTest, ParsesConfigurationBools) {
CHECK_PARSE_BOOL(IndentAccessModifiers);
CHECK_PARSE_BOOL(IndentCaseLabels);
CHECK_PARSE_BOOL(IndentCaseBlocks);
- CHECK_PARSE_BOOL(IndentGotoLabels);
+ CHECK_PARSE_ENUM(IndentGotoLabels,
https://github.com/HazardyKnusperkeks requested changes to this pull request.
Do you actually want to use that feature, or do you only want to work on
something?
Please take a greater look on how enums are documented, parsed, and tested. A
fairly recent example which transitioned from `bool` w
@@ -2432,9 +2431,25 @@ struct FormatStyle {
///label2:label2:
/// return 1; return 1;
///} }
+ ///
+ ///GLI_HalfIndent:
+ ///int f() {
+ /// if
https://github.com/varshneydevansh updated
https://github.com/llvm/llvm-project/pull/65140:
>From be006b494c4e34463818a7f1fd30cde9282fcea1 Mon Sep 17 00:00:00 2001
From: varshneydevansh
Date: Thu, 31 Aug 2023 17:27:58 +0530
Subject: [PATCH 1/3] [clang] modified goto bool to enum
---
clang/doc
@@ -2432,9 +2431,25 @@ struct FormatStyle {
///label2:label2:
/// return 1; return 1;
///} }
+ ///
+ ///GLI_HalfIndent:
+ ///int f() {
+ /// if
https://github.com/varshneydevansh review_requested
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/varshneydevansh review_requested
https://github.com/llvm/llvm-project/pull/65140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/varshneydevansh updated
https://github.com/llvm/llvm-project/pull/65140:
>From be006b494c4e34463818a7f1fd30cde9282fcea1 Mon Sep 17 00:00:00 2001
From: varshneydevansh
Date: Thu, 31 Aug 2023 17:27:58 +0530
Subject: [PATCH 1/2] [clang] modified goto bool to enum
---
clang/doc
34 matches
Mail list logo
