https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.ll
weliveindetail wrote:
Thanks for your feedback everyone!
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/97071
From ca2ab5f9e3470e87923c7b950b7b06e5ff21119e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 28 Jun 2024 16:43:42 +0200
Subject: [PATCH 1/3] [clang-repl] Fix RuntimeInterfaceBu
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Also remove the comment that links to
https://github.com/llvm/llvm-project/issues/94994 and add `Fixes #94994` to the
commit message.
https://github.com/llvm/llvm-project/pull/97071
eymay wrote:
Great work, I can imagine how hard it would be to uncover it!
Small note: I think you may also want to remove the Arm macro guards that mask
the unittest in the same commit, as you did in the previous
[PR](https://github.com/llvm/llvm-project/pull/96900/files#diff-9b27f347e7ca15f9
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
weliveindetail wrote:
> Any chance of adding a test case?
We could add a lot more tests in general, but I don't think this specific
detail requires a dedicated one. It's a fix for an existing bug, so we have
coverage already.
https://github.com/llvm/llvm-project/pull/97071
___
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/97071
From ca2ab5f9e3470e87923c7b950b7b06e5ff21119e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 28 Jun 2024 16:43:42 +0200
Subject: [PATCH 1/2] [clang-repl] Fix RuntimeInterfaceBu
@@ -673,10 +673,12 @@ class InterfaceKindVisitor
}
private:
- // Force cast these types to uint64 to reduce the number of overloads of
- // `__clang_Interpreter_SetValueNoAlloc`.
+ // Force cast these types to the uint that fits the register size. That way
we
+ // reduc
https://github.com/vgvassilev approved this pull request.
Oh, that's a good catch. Any chance of adding a test case? Maybe something like:
```enum X : short {...}```?
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-com
https://github.com/vgvassilev edited
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Stefan Gränitz (weliveindetail)
Changes
When generating runtime interface bindings, extend integral types to the native
register size rather than 64-bit per se
---
Full diff: https://github.com/llvm/llvm-project/pull/97071.diff
1 Files
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/97071
When generating runtime interface bindings, extend integral types to the native
register size rather than 64-bit per se
From ca2ab5f9e3470e87923c7b950b7b06e5ff21119e Mon Sep 17 00:00:00 2001
From: =?UTF-8
15 matches
Mail list logo
