[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/85378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

Stefan =?utf-8?q?Gränitz?= Message-ID: In-Reply-To: @@ -375,16 +375,22 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit &PTU) { TranslationUnitDecl *MostRecentTU = PTU.TUPart; TranslationUnitDecl *FirstTU = MostRecentTU->getFirstDecl(); if (StoredDeclsMap

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

@@ -375,16 +375,22 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit &PTU) { TranslationUnitDecl *MostRecentTU = PTU.TUPart; TranslationUnitDecl *FirstTU = MostRecentTU->getFirstDecl(); if (StoredDeclsMap *Map = FirstTU->getPrimaryContext()->getLookupPtr()) {

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

@@ -375,16 +375,22 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit &PTU) { TranslationUnitDecl *MostRecentTU = PTU.TUPart; TranslationUnitDecl *FirstTU = MostRecentTU->getFirstDecl(); if (StoredDeclsMap *Map = FirstTU->getPrimaryContext()->getLookupPtr()) {

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

Stefan =?utf-8?q?Gränitz?= Message-ID: In-Reply-To: @@ -375,16 +375,22 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit &PTU) { TranslationUnitDecl *MostRecentTU = PTU.TUPart; TranslationUnitDecl *FirstTU = MostRecentTU->getFirstDecl(); if (StoredDeclsMap

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

Stefan =?utf-8?q?Gränitz?= Message-ID: In-Reply-To: @@ -375,16 +375,22 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit &PTU) { TranslationUnitDecl *MostRecentTU = PTU.TUPart; TranslationUnitDecl *FirstTU = MostRecentTU->getFirstDecl(); if (StoredDeclsMap

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

@@ -205,7 +205,7 @@ class StoredDeclsList { Data.setPointer(Head); } - /// Return an array of all the decls that this list represents. + /// Return the list of all the decls. weliveindetail wrote: This is not an array (otherwise we could have done era

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

@@ -375,16 +375,22 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit &PTU) { TranslationUnitDecl *MostRecentTU = PTU.TUPart; TranslationUnitDecl *FirstTU = MostRecentTU->getFirstDecl(); if (StoredDeclsMap *Map = FirstTU->getPrimaryContext()->getLookupPtr()) {

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

https://github.com/weliveindetail commented: Two minor remarks https://github.com/llvm/llvm-project/pull/85378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

https://github.com/weliveindetail edited https://github.com/llvm/llvm-project/pull/85378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

https://github.com/weliveindetail updated https://github.com/llvm/llvm-project/pull/85378 From 6fbd6e36133af7af008c84a1a2e44c243aed26be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?= Date: Fri, 15 Mar 2024 11:01:09 +0100 Subject: [PATCH 1/2] [clang-repl] Fix assertion failure

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

https://github.com/vgvassilev approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/85378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

vgvassilev wrote: Okay, sounds fair. https://github.com/llvm/llvm-project/pull/85378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

weliveindetail wrote: I can reproduce it downstream in the implicit Undo after including a header that causes a lot of parse errors in nested headers. I am afraid it's unpractical to emulate in the test suite upstream. The code is exercised in all Undo tests. They don't reproduce the issue rig

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

vgvassilev wrote: Nice catch! Any chance for having a test? https://github.com/llvm/llvm-project/pull/85378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Stefan Gränitz (weliveindetail) Changes This assertion failure is one (fortunate) symptom: ``` clang/include/clang/AST/DeclBase.h:1337: reference clang::DeclListNode::iterator::operator*() const: Assertion `Ptr && "dereferencing end() ite

[clang] [clang-repl] Fix assertion failure in CleanUpPTU() (PR #85378)

https://github.com/weliveindetail created https://github.com/llvm/llvm-project/pull/85378 This assertion failure is one (fortunate) symptom: ``` clang/include/clang/AST/DeclBase.h:1337: reference clang::DeclListNode::iterator::operator*() const: Assertion `Ptr && "dereferencing end() iterator"