https://github.com/vgvassilev closed
https://github.com/llvm/llvm-project/pull/86402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/86402
>From ac273dc784a356f6b61e0928b02cdd74418846ce Mon Sep 17 00:00:00 2001
From: Anubhab Ghosh
Date: Sat, 23 Mar 2024 15:13:57 +
Subject: [PATCH] [clang-repl] Support wasm execution.
This commit introduces s
vgvassilev wrote:
Thank you for letting this move forward!
https://github.com/llvm/llvm-project/pull/86402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/86402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
I don't have expertise with wasm, but the changes seem reasonable to me --
LGTM, but maybe wait a few days before landing in case other reviewers have
concerns.
https://github.com/llvm/llvm-project/pull/86402
_
vgvassilev wrote:
@AaronBallman do we have access to some existing bot to set it up as @argentite
suggests?
https://github.com/llvm/llvm-project/pull/86402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
argentite wrote:
> Unfortunately, this PR cannot be tested in the current testing infrastructure
> in llvm because it needs a browser to provide a proper execution environment.
Just to clarify, we don't need an actual full browser to test it. Nodejs should
probably be sufficient for execution.
AaronBallman wrote:
> > > > > @AaronBallman, to be fair, clang is testing the wasm features in
> > > > > terms of output. So this is wiring up a bunch of tested features that
> > > > > will allow execution. Clang generally does not test execution but
> > > > > output, so we are not creating a
vgvassilev wrote:
> > > > @AaronBallman, to be fair, clang is testing the wasm features in terms
> > > > of output. So this is wiring up a bunch of tested features that will
> > > > allow execution. Clang generally does not test execution but output, so
> > > > we are not creating a precedent
DerThorsten wrote:
> > > @AaronBallman, to be fair, clang is testing the wasm features in terms of
> > > output. So this is wiring up a bunch of tested features that will allow
> > > execution. Clang generally does not test execution but output, so we are
> > > not creating a precedent here si
vgvassilev wrote:
> > > > @AaronBallman, to be fair, clang is testing the wasm features in terms
> > > > of output. So this is wiring up a bunch of tested features that will
> > > > allow execution. Clang generally does not test execution but output, so
> > > > we are not creating a precedent
AaronBallman wrote:
> > > @AaronBallman, to be fair, clang is testing the wasm features in terms of
> > > output. So this is wiring up a bunch of tested features that will allow
> > > execution. Clang generally does not test execution but output, so we are
> > > not creating a precedent here s
vgvassilev wrote:
> > @AaronBallman, to be fair, clang is testing the wasm features in terms of
> > output. So this is wiring up a bunch of tested features that will allow
> > execution. Clang generally does not test execution but output, so we are
> > not creating a precedent here since that
AaronBallman wrote:
> @AaronBallman, to be fair, clang is testing the wasm features in terms of
> output. So this is wiring up a bunch of tested features that will allow
> execution. Clang generally does not test execution but output, so we are not
> creating a precedent here since that PR can
vgvassilev wrote:
@AaronBallman, to be fair, clang is testing the wasm features in terms of
output. So this is wiring up a bunch of tested features that will allow
execution. Clang generally does not test execution but output, so we are not
creating a precedent here since that PR can be consid
vgvassilev wrote:
That would make sense. I am not sure if we can set a post commit bot though.
@argentite what do you think?
https://github.com/llvm/llvm-project/pull/86402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
AaronBallman wrote:
So are we in a chicken-and-egg situation where we need some support in-tree in
order to have a reason to set up a postcommit test bot but we don't want to
land untested changes?
At the end of the day, if we're claiming support for something, we need it to
be tested and thi
vgvassilev wrote:
Hi @AaronBallman, we need some leadership here.
This pull request teaches clang-repl to work inside a browser. It enables
webassembly [xeus-cpp](https://github.com/compiler-research/xeus-cpp) (through
clang-repl) which connects to the JupyterLite infrastructure. This change
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/86402
>From e1e3b1ec07133fb67b4f98c6696e330fdedf2460 Mon Sep 17 00:00:00 2001
From: Anubhab Ghosh
Date: Sat, 23 Mar 2024 15:13:57 +
Subject: [PATCH] [clang-repl] Support wasm execution.
This commit introduces s
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/86402
>From 6b94e0cd67e59a7fcde2a327d6565a3850dc5f50 Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Thu, 30 May 2024 05:08:17 +
Subject: [PATCH 1/2] Revert "Revert "[clang-repl] Extend the C support.
(#89
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/86402
>From 4434ceeef152b95998ebd0a3b09a56d105490c4d Mon Sep 17 00:00:00 2001
From: Anubhab Ghosh
Date: Sat, 23 Mar 2024 15:13:57 +
Subject: [PATCH 1/3] [clang-repl] Support wasm execution.
This commit introduc
https://github.com/argentite updated
https://github.com/llvm/llvm-project/pull/86402
>From 4434ceeef152b95998ebd0a3b09a56d105490c4d Mon Sep 17 00:00:00 2001
From: Anubhab Ghosh
Date: Sat, 23 Mar 2024 15:13:57 +
Subject: [PATCH 1/3] [clang-repl] Support wasm execution.
This commit introduce
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/86402
>From 4434ceeef152b95998ebd0a3b09a56d105490c4d Mon Sep 17 00:00:00 2001
From: Anubhab Ghosh
Date: Sat, 23 Mar 2024 15:13:57 +
Subject: [PATCH 1/2] [clang-repl] Support wasm execution.
This commit introduc
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
vgvassilev wrote:
cc: @sylvaincorlay, @JohanMabille, @anutosh491
https://github.com/llvm/llvm-project/pull/86402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vassil Vassilev (vgvassilev)
Changes
This commit introduces support for running clang-repl and executing C++ code
interactively inside a Javascript engine using WebAssembly when built with
Emscripten. This is achieved by producing WASM "s
https://github.com/vgvassilev created
https://github.com/llvm/llvm-project/pull/86402
This commit introduces support for running clang-repl and executing C++ code
interactively inside a Javascript engine using WebAssembly when built with
Emscripten. This is achieved by producing WASM "shared l
28 matches
Mail list logo