[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/75545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

https://github.com/ChuanqiXu9 approved this pull request. LGTM then. https://github.com/llvm/llvm-project/pull/75545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

https://github.com/jansvoboda11 approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/75545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

@@ -728,7 +728,7 @@ getCompilationDataBase(int argc, char **argv, std::string &ErrorMessage) { *Diags); std::unique_ptr C( TheDriver.BuildCompilation(CommandLine)); - if (!C) + if (C->getJobs().empty()) Yaraslaut wrote: Co

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

https://github.com/Yaraslaut updated https://github.com/llvm/llvm-project/pull/75545 >From 79c0d0a8304184f276a6f854500b8965eb2b5c3f Mon Sep 17 00:00:00 2001 From: Yaraslau Tamashevich Date: Fri, 15 Dec 2023 01:57:15 +0200 Subject: [PATCH] Fix check for empty Compilation --- clang/tools/clang-

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/75545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

@@ -728,7 +728,7 @@ getCompilationDataBase(int argc, char **argv, std::string &ErrorMessage) { *Diags); std::unique_ptr C( TheDriver.BuildCompilation(CommandLine)); - if (!C) + if (C->getJobs().empty()) ChuanqiXu9 wrote: `

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

https://github.com/ChuanqiXu9 commented: It will be better to have a test for this. https://github.com/llvm/llvm-project/pull/75545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

Yaraslaut wrote: ping https://github.com/llvm/llvm-project/pull/75545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaraslau (Yaraslaut) Changes Closes https://github.com/llvm/llvm-project/issues/64144 Instead of checking for `nullptr` we need to ensure that `JobList` is not empty to proceed --- Full diff: https://github.com/llvm/llvm-project/pull/75

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

https://github.com/Yaraslaut created https://github.com/llvm/llvm-project/pull/75545 Closes https://github.com/llvm/llvm-project/issues/64144 Instead of checking for `nullptr` we need to ensure that `JobList` is not empty to proceed >From 052a12dfb78ddc7b1486ca5f8e06002bb55c1d2e Mon Sep 17 0