AngryLoki wrote:
This is going nowhere, I'll close it and create a separate PR for libcxx.
Also `transitive_includes.gen.py` somehow (due to automatic git conflict
resolution?) got damaged indentations, so it would require new review anyways.
https://github.com/llvm/llvm-project/pull/86806
https://github.com/AngryLoki closed
https://github.com/llvm/llvm-project/pull/86806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Can we either finish this up or close it, please? I'd like to tidy up the
libc++ review queue.
https://github.com/llvm/llvm-project/pull/86806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -101,7 +101,7 @@ def extract_result_types(comment):
def strip_doxygen(comment):
-"""Returns the given comment without \-escaped words."""
+"""Returns the given comment without \\-escaped words."""
AngryLoki wrote:
No, `'''\-'''` is still
@@ -101,7 +101,7 @@ def extract_result_types(comment):
def strip_doxygen(comment):
-"""Returns the given comment without \-escaped words."""
+"""Returns the given comment without \\-escaped words."""
ellishg wrote:
I see lots of changes to comment
https://github.com/kastiglione commented:
lldb/package looks good, thanks.
lldb/examples I trust
lldb/test I or someone else will look at soon.
https://github.com/llvm/llvm-project/pull/86806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -1517,7 +1517,7 @@ def buildLibrary(self, sources, lib_name):
"DYLIB_NAME": lib_name,
"CFLAGS_EXTRAS": "%s -I%s "
% (stdflag, os.path.join(os.environ["LLDB_SRC"], "include")),
-"LD_EXTRAS": "-shared
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/86806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AngryLoki wrote:
But automatic replacement is not possible, because `"\n" != r"\n"`. But I
checked carefully that all changed places with `\n` and `\t` are regexps, and
in regexps it is semantically the same.
```
>>> '\n' in 'test \n test'
True
>>> r'\n' in
fmayer wrote:
LGTM, verified the two strings are the same
```
>>> r"^(.*) \(in (.*)\) \((.*:\d*)\)$" == "^(.*) \(in (.*)\) \((.*:\d*)\)$"
True
>>> "^( *#([0-9]+) *)(0x[0-9a-f]+) *(?:in *.+)? *\((.*)\+(0x[0-9a-f]+)\)" ==
>>> r"^( *#([0-9]+) *)(0x[0-9a-f]+)
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
e82765bf07a978674c0e75c8b2e20f154ae24a4c...c7d6289573379be760ca9d691d62e0f87ba0ee8a
https://github.com/ldionne approved this pull request.
Libc++ parts LGTM.
https://github.com/llvm/llvm-project/pull/86806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-libcxx
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-mlir
Author: None (AngryLoki)
Changes
This fixes "SyntaxWarning: invalid escape sequence" and "SyntaxWarning: "is"
with 'int' literal",
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
14 matches
Mail list logo
