https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
I believe the concerns from @asl and @tbaederr have been addressed and we're
fine to land this, but I'll land it tomorrow to give them both a chance to
weigh-in and to give precommit CI a chance to finish.
https://github.com/llvm/llvm-project/pull/78338
https://github.com/AaronBallman approved this pull request.
LGTM, thank you!
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/22] Fix : more detailed no expected directive message
---
@@ -396,6 +396,15 @@ class VerifyDiagnosticConsumer::MarkerTracker {
}
};
+std::string DetailedErrorString(DiagnosticsEngine ) {
+ std::string ErrDirective;
+ if (Diags.getDiagnosticOptions().VerifyPrefixes.empty())
+ErrDirective = "expected";
+ else
+
https://github.com/AaronBallman commented:
Thank you, aside from some small suggestions, this LGTM
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
Thanks a lot for looking
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/19] Fix : more detailed no expected directive message
---
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
@AaronBallman, I don't
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/17] Fix : more detailed no expected directive message
---
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
def err_verify_no_directives : Error<
-"no expected
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
def err_verify_no_directives : Error<
-"no expected
tbaederr wrote:
Adding Aaron since we're probably getting close.
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
-
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
The policy is to ping _once a week_. It's the weekend.
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asl requested changes to this pull request.
Ensure that PR does not contain unrelated things. See
https://llvm.org/docs/Contributing.html#how-to-submit-a-patch for more
information
https://github.com/llvm/llvm-project/pull/78338
Sh0g0-1758 wrote:
Here is a working implementation of the second issue that I aim to solve.
https://github.com/llvm/llvm-project/pull/78338
Sh0g0-1758 wrote:
I have pushed code in this PR that aims to solve this
[issue](https://github.com/llvm/llvm-project/pull/66540) also.
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Sh0g0-1758 wrote:
Here you can see a working implementation of the asked feature.
https://github.com/llvm/llvm-project/pull/78338
22 matches
Mail list logo
