[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

fawdlstty wrote:  https://github.com/llvm/llvm-project/pull/106581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/fawdlstty updated https://github.com/llvm/llvm-project/pull/106581 >From f169f3c57a0a55c1a0dbb8f965bc17a87ceb98d7 Mon Sep 17 00:00:00 2001 From: fawdlstty Date: Fri, 30 Aug 2024 00:23:39 +0800 Subject: [PATCH 1/6] add check for windows platforms api --- .../bugprone/NotNull

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/fawdlstty updated https://github.com/llvm/llvm-project/pull/106581 >From f169f3c57a0a55c1a0dbb8f965bc17a87ceb98d7 Mon Sep 17 00:00:00 2001 From: fawdlstty Date: Fri, 30 Aug 2024 00:23:39 +0800 Subject: [PATCH 1/5] add check for windows platforms api --- .../bugprone/NotNull

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/fawdlstty updated https://github.com/llvm/llvm-project/pull/106581 >From f169f3c57a0a55c1a0dbb8f965bc17a87ceb98d7 Mon Sep 17 00:00:00 2001 From: fawdlstty Date: Fri, 30 Aug 2024 00:23:39 +0800 Subject: [PATCH 1/4] add check for windows platforms api --- .../bugprone/NotNull

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/fawdlstty updated https://github.com/llvm/llvm-project/pull/106581 >From f169f3c57a0a55c1a0dbb8f965bc17a87ceb98d7 Mon Sep 17 00:00:00 2001 From: fawdlstty Date: Fri, 30 Aug 2024 00:23:39 +0800 Subject: [PATCH 1/3] add check for windows platforms api --- .../bugprone/NotNull

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/fawdlstty updated https://github.com/llvm/llvm-project/pull/106581 >From f169f3c57a0a55c1a0dbb8f965bc17a87ceb98d7 Mon Sep 17 00:00:00 2001 From: fawdlstty Date: Fri, 30 Aug 2024 00:23:39 +0800 Subject: [PATCH 1/2] add check for windows platforms api --- .../bugprone/NotNull

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/106581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

@@ -158,12 +160,16 @@ class CStringChecker : public Checker< eval::Call, &CStringChecker::evalStrlcpy}, {{CDM::CLibraryMaybeHardened, {"strcat"}, 2}, &CStringChecker::evalStrcat}, + {{CDM::CLibraryMaybeHardened, {"lstrcat"}, 2}, + &CStringChecker:

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

@@ -150,6 +150,8 @@ class CStringChecker : public Checker< eval::Call, // FIXME: C23 introduces 'memset_explicit', maybe also model that {{CDM::CLibraryMaybeHardened, {"strcpy"}, 2}, &CStringChecker::evalStrcpy}, + {{CDM::CLibraryMaybeHardened, {"lstrcpy

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

@@ -158,12 +160,16 @@ class CStringChecker : public Checker< eval::Call, &CStringChecker::evalStrlcpy}, {{CDM::CLibraryMaybeHardened, {"strcat"}, 2}, &CStringChecker::evalStrcat}, + {{CDM::CLibraryMaybeHardened, {"lstrcat"}, 2}, NagyDon

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/106581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/NagyDonat commented: (This is just a quick drive-by correction of the `CallDescription` matching modes. Other parts of the commit seem to be good, but I don't have a firm opinion.) https://github.com/llvm/llvm-project/pull/106581 _

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/106581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

https://github.com/steakhal requested changes to this pull request. Looks good overall. I have mixed feelings about combining semantic changes across semi-subprojects like builtins, clang-tidy and the clang static analyzer. Could you please demonstrate the improvements on tests? https://github.