[clang] [clang codegen][NFC] Delete dead code in constant emission. (PR #90106)

2024-04-25 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/90106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang codegen][NFC] Delete dead code in constant emission. (PR #90106)

2024-04-25 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Oh, I was confused that we had this code that doesn't appear to be doing anything. If you actually have a plan, then we can keep it for now, I guess. It might make sense to try to clarify some of the address-space related APIs: if the caller doesn't want placeholder-stuff

[clang] [clang codegen][NFC] Delete dead code in constant emission. (PR #90106)

2024-04-25 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: The Apple fork does actually use this downstream (for address-sensitive `__ptrauth`), and we've recently (finally) been making progress in upstreaming that work. Obviously, we could delete it and then reinstate it when we catch up to this point in upstre

[clang] [clang codegen][NFC] Delete dead code in constant emission. (PR #90106)

2024-04-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 758d97dce0c669a0ba6927728b40030a76acb144 b9e5e50524a6ff91badfd5729846d5c948f1d4ce --

[clang] [clang codegen][NFC] Delete dead code in constant emission. (PR #90106)

2024-04-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Eli Friedman (efriedma-quic) Changes This code was apparently added in de0fe07eef, but never used. I think more of the related code might actually dead, but I haven't tried to dig more deeply. --- Full diff: https://github.com/ll

[clang] [clang codegen][NFC] Delete dead code in constant emission. (PR #90106)

2024-04-25 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic created https://github.com/llvm/llvm-project/pull/90106 This code was apparently added in de0fe07eef, but never used. I think more of the related code might actually dead, but I haven't tried to dig more deeply. >From b9e5e50524a6ff91badfd5729846d5c948f1d4ce M