https://github.com/efriedma-quic closed
https://github.com/llvm/llvm-project/pull/90151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/90151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
Added release note.
https://github.com/llvm/llvm-project/pull/90151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic updated
https://github.com/llvm/llvm-project/pull/90151
>From 9adeffc9ee780c84a525ce0535a84508105e05ae Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Thu, 25 Apr 2024 17:06:40 -0700
Subject: [PATCH 1/2] [clang codegen] Fix MS ABI detection of user-provided
c
@@ -201,3 +201,17 @@ S11 f11() {
S11 x;
return func11(x);
}
+
cor3ntin wrote:
```suggestion
//GH86384
```
https://github.com/llvm/llvm-project/pull/90151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cor3ntin approved this pull request.
Can you add a changelog entry mentioning the fixed issue ?
Otherwise LGTM
https://github.com/llvm/llvm-project/pull/90151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/90151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Eli Friedman (efriedma-quic)
Changes
In the context of determining whether a class counts as an "aggregate", a
constructor template counts as a user-provided constructor.
Fixes #86384
---
Full diff: https://github.com/llvm/llvm-p
https://github.com/efriedma-quic created
https://github.com/llvm/llvm-project/pull/90151
In the context of determining whether a class counts as an "aggregate", a
constructor template counts as a user-provided constructor.
Fixes #86384
>From 9adeffc9ee780c84a525ce0535a84508105e05ae Mon Sep 17