https://github.com/karka228 closed
https://github.com/llvm/llvm-project/pull/120321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/120321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 edited
https://github.com/llvm/llvm-project/pull/120321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
thanks!
https://github.com/llvm/llvm-project/pull/120321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
karka228 wrote:
I have now renamed the file to AllDiagnosticKinds.inc
https://github.com/llvm/llvm-project/pull/120321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -0,0 +1,31 @@
+//===--- DiagnosticIDs.inc --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/120321
>From 1ad62a9a136a5ae80c880459472a88517afe75a4 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 17 Dec 2024 22:48:04 +0100
Subject: [PATCH 1/3] [diagtool] Make the BuiltinDiagnosticsByID table sort
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/120321
>From 1ad62a9a136a5ae80c880459472a88517afe75a4 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 17 Dec 2024 22:48:04 +0100
Subject: [PATCH 1/3] [diagtool] Make the BuiltinDiagnosticsByID table sort
@@ -0,0 +1,31 @@
+//===--- DiagnosticIDs.inc --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
kadircet wrote:
we already have a concept of `DiagnosticID`. can we rename this to
`AllDiagnosticKinds.inc` ?
https://github.com/llvm/llvm-project/pull/120321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/120321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,31 @@
+//===--- DiagnosticIDs.inc --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -23,28 +23,29 @@ llvm::ArrayRef
diagtool::getBuiltinDiagnosticsByName() {
return llvm::ArrayRef(BuiltinDiagnosticsByName);
}
-
// FIXME: Is it worth having two tables, especially when this one can get
// out of sync easily?
+// clang-format off
karka22
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/120321
>From 1ad62a9a136a5ae80c880459472a88517afe75a4 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 17 Dec 2024 22:48:04 +0100
Subject: [PATCH 1/2] [diagtool] Make the BuiltinDiagnosticsByID table sort
@@ -23,28 +23,29 @@ llvm::ArrayRef
diagtool::getBuiltinDiagnosticsByName() {
return llvm::ArrayRef(BuiltinDiagnosticsByName);
}
-
// FIXME: Is it worth having two tables, especially when this one can get
// out of sync easily?
+// clang-format off
static const Diagnostic
@@ -23,28 +23,29 @@ llvm::ArrayRef
diagtool::getBuiltinDiagnosticsByName() {
return llvm::ArrayRef(BuiltinDiagnosticsByName);
}
-
// FIXME: Is it worth having two tables, especially when this one can get
// out of sync easily?
+// clang-format off
kadirce
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/120321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -23,28 +23,29 @@ llvm::ArrayRef
diagtool::getBuiltinDiagnosticsByName() {
return llvm::ArrayRef(BuiltinDiagnosticsByName);
}
-
// FIXME: Is it worth having two tables, especially when this one can get
// out of sync easily?
+// clang-format off
static const Diagnostic
@@ -23,28 +23,29 @@ llvm::ArrayRef
diagtool::getBuiltinDiagnosticsByName() {
return llvm::ArrayRef(BuiltinDiagnosticsByName);
}
-
// FIXME: Is it worth having two tables, especially when this one can get
// out of sync easily?
+// clang-format off
static const Diagnostic
@@ -23,28 +23,29 @@ llvm::ArrayRef
diagtool::getBuiltinDiagnosticsByName() {
return llvm::ArrayRef(BuiltinDiagnosticsByName);
}
-
// FIXME: Is it worth having two tables, especially when this one can get
// out of sync easily?
+// clang-format off
karka22
bjope wrote:
Added some reviewers based on people that have touched code related to
"diagnostics" (but don't really know much about the fix, nor who might know
anything about this particular code in diagtool). Feel free to redirect to
someone else (or let me know if I should try to find other
21 matches
Mail list logo
