[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2024-01-17 Thread Philip Reames via cfe-commits
preames wrote: Not actively working on this. Anyone interested is welcome to pick up the patch. https://github.com/llvm/llvm-project/pull/74770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2024-01-17 Thread Philip Reames via cfe-commits
https://github.com/preames closed https://github.com/llvm/llvm-project/pull/74770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2023-12-08 Thread Andrzej WarzyƄski via cfe-commits
banach-space wrote: The current setting pre-dates the visibility flags, so it makes sense that it wouldn't be needed anymore. This change makes sense to me, but it would be nice to verify. > I don't see any testing in tree for anything except clang What tests do you see in Clang for this

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2023-12-07 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: It seems reasonable. You may consider adding test to clang/test/Driver/autocomplete.c https://github.com/llvm/llvm-project/pull/74770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2023-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 58c2a4e806b2882c0622cbded923b32f94c5b47b 255c261df90bd15d3bcee7a212758c2de4c56e69 --

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2023-12-07 Thread Philip Reames via cfe-commits
https://github.com/preames edited https://github.com/llvm/llvm-project/pull/74770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Philip Reames (preames) Changes The previous code was always auto-completing options for the clang mode. We'd special cases flang to allow both clang and flang options, but this doesn't match either the help output or the actual

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2023-12-07 Thread Philip Reames via cfe-commits
https://github.com/preames created https://github.com/llvm/llvm-project/pull/74770 The previous code was always auto-completing options for the clang mode. We'd special cases flang to allow both clang and flang options, but this doesn't match either the help output or the actual argument