[clang] [flang] [flang][nfc] Refactor linker invocation logic (PR #75534)

2023-12-15 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: > After this change, I can no longer use flang-new to create an executable > program. When I try, I get the following output: > > ``` > [psteinfeld@ice4 build]$ flang-new hello.f90 > /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../bin/ld: >

[clang] [flang] [flang][nfc] Refactor linker invocation logic (PR #75534)

2023-12-15 Thread Pete Steinfeld via cfe-commits
https://github.com/psteinfeld commented: After this change, I can no longer use flang-new to create an executable program. When I try, I get the following output: ``` [psteinfeld@ice4 build]$ flang-new hello.f90

[clang] [flang] [flang][nfc] Refactor linker invocation logic (PR #75534)

2023-12-15 Thread Michael Klemm via cfe-commits
@@ -1116,73 +1116,87 @@ bool tools::addOpenMPRuntime(ArgStringList , const ToolChain , return true; } +/// Determines if --whole-archive is active in the list of arguments. +static bool isWholeArchivePresent(const ArgList ) { + bool WholeArchiveActive = false; + for

[clang] [flang] [flang][nfc] Refactor linker invocation logic (PR #75534)

2023-12-15 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space closed https://github.com/llvm/llvm-project/pull/75534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][nfc] Refactor linker invocation logic (PR #75534)

2023-12-15 Thread Andrzej Warzyński via cfe-commits
@@ -1116,73 +1116,87 @@ bool tools::addOpenMPRuntime(ArgStringList , const ToolChain , return true; } +/// Determines if --whole-archive is active in the list of arguments. +static bool isWholeArchivePresent(const ArgList ) { + bool WholeArchiveActive = false; + for

[clang] [flang] [flang][nfc] Refactor linker invocation logic (PR #75534)

2023-12-15 Thread Michael Klemm via cfe-commits
@@ -1116,73 +1116,87 @@ bool tools::addOpenMPRuntime(ArgStringList , const ToolChain , return true; } +/// Determines if --whole-archive is active in the list of arguments. +static bool isWholeArchivePresent(const ArgList ) { + bool WholeArchiveActive = false; + for

[clang] [flang] [flang][nfc] Refactor linker invocation logic (PR #75534)

2023-12-15 Thread Michael Klemm via cfe-commits
https://github.com/mjklemm approved this pull request. LGTM! Thanks for the refactoring. This makes the code much easier to digest! https://github.com/llvm/llvm-project/pull/75534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang] [flang][nfc] Refactor linker invocation logic (PR #75534)

2023-12-14 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space updated https://github.com/llvm/llvm-project/pull/75534 From b0b3bc42f0d6cb881ee0d028d2cc358ba3a347ed Mon Sep 17 00:00:00 2001 From: Andrzej Warzynski Date: Thu, 14 Dec 2023 21:34:11 + Subject: [PATCH] [flang][nfc] Refactor linker invocation logic Refactor