banach-space wrote:
> I don't feel strongly about it
ACK.
I mostly care about consistency in the interface exposed to the end-user. TBH,
I've never really investigated the relationship of `-O{0|1|2|3|4}` with various
feature flags. What I described definitely holds for
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/73111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList ,
if (shouldLoopVersion(Args))
CmdArgs.push_back("-fversion-loops-for-stride");
+ Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis,
+
https://github.com/kiranchandramohan approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/73111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2,12 +2,25 @@
! See flang/test/Fir/tbaa-codegen.fir for a test that the output is correct
! RUN: %flang -c -emit-llvm -falias-analysis %s -o - | llvm-dis | FileCheck %s
--check-prefix=CHECK-AA --check-prefix=CHECK-ALL
-! RUN: %flang -c -emit-llvm -falias-analysis
@@ -142,6 +142,24 @@ void Flang::addCodegenOptions(const ArgList ,
if (shouldLoopVersion(Args))
CmdArgs.push_back("-fversion-loops-for-stride");
+ Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis,
+
@@ -2,12 +2,25 @@
! See flang/test/Fir/tbaa-codegen.fir for a test that the output is correct
! RUN: %flang -c -emit-llvm -falias-analysis %s -o - | llvm-dis | FileCheck %s
--check-prefix=CHECK-AA --check-prefix=CHECK-ALL
-! RUN: %flang -c -emit-llvm -falias-analysis
@@ -242,10 +242,24 @@ static void
parseCodeGenArgs(Fortran::frontend::CodeGenOptions ,
clang::driver::options::OPT_fno_loop_versioning, false))
opts.LoopVersioning = 1;
- opts.AliasAnalysis =
-
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/73111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/73111
>From 617d6d23b2f861cd6dceb82f54a2685059b6 Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Thu, 14 Sep 2023 09:09:29 +
Subject: [PATCH 1/6] [flang] Enable alias tags pass by default
Enable by default when
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList ,
if (shouldLoopVersion(Args))
CmdArgs.push_back("-fversion-loops-for-stride");
+ Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis,
+
@@ -242,10 +242,24 @@ static void
parseCodeGenArgs(Fortran::frontend::CodeGenOptions ,
clang::driver::options::OPT_fno_loop_versioning, false))
opts.LoopVersioning = 1;
- opts.AliasAnalysis =
-
@@ -242,10 +242,24 @@ static void
parseCodeGenArgs(Fortran::frontend::CodeGenOptions ,
clang::driver::options::OPT_fno_loop_versioning, false))
opts.LoopVersioning = 1;
- opts.AliasAnalysis =
-
@@ -242,10 +242,24 @@ static void
parseCodeGenArgs(Fortran::frontend::CodeGenOptions ,
clang::driver::options::OPT_fno_loop_versioning, false))
opts.LoopVersioning = 1;
- opts.AliasAnalysis =
-
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList ,
if (shouldLoopVersion(Args))
CmdArgs.push_back("-fversion-loops-for-stride");
+ Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis,
+
https://github.com/banach-space edited
https://github.com/llvm/llvm-project/pull/73111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -242,10 +242,24 @@ static void
parseCodeGenArgs(Fortran::frontend::CodeGenOptions ,
clang::driver::options::OPT_fno_loop_versioning, false))
opts.LoopVersioning = 1;
- opts.AliasAnalysis =
-
tblah wrote:
> Thank you for the changes, Tom!
>
> I have one minor comment, but I would like to ask to merge this after US
> holidays, if possible. Could you please postpone the merging until Monday GMT?
Sure. I'll wait until Monday.
https://github.com/llvm/llvm-project/pull/73111
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList ,
if (shouldLoopVersion(Args))
CmdArgs.push_back("-fversion-loops-for-stride");
+ Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis,
+
https://github.com/vzakhari commented:
Thank you for the changes, Tom!
I have one minor comment, but I would like to ask to merge this after US
holidays, if possible. Could you please postpone the merging until Monday GMT?
https://github.com/llvm/llvm-project/pull/73111
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/73111
>From 617d6d23b2f861cd6dceb82f54a2685059b6 Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Thu, 14 Sep 2023 09:09:29 +
Subject: [PATCH 1/3] [flang] Enable alias tags pass by default
Enable by default when
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList ,
if (shouldLoopVersion(Args))
CmdArgs.push_back("-fversion-loops-for-stride");
+ Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis,
+
@@ -242,10 +242,24 @@ static void
parseCodeGenArgs(Fortran::frontend::CodeGenOptions ,
clang::driver::options::OPT_fno_loop_versioning, false))
opts.LoopVersioning = 1;
- opts.AliasAnalysis =
-
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList ,
if (shouldLoopVersion(Args))
CmdArgs.push_back("-fversion-loops-for-stride");
+ Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis,
+
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList ,
if (shouldLoopVersion(Args))
CmdArgs.push_back("-fversion-loops-for-stride");
+ Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis,
+
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList ,
if (shouldLoopVersion(Args))
CmdArgs.push_back("-fversion-loops-for-stride");
+ Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis,
+
https://github.com/banach-space edited
https://github.com/llvm/llvm-project/pull/73111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/martinboehme updated
https://github.com/llvm/llvm-project/pull/73111
>From 617d6d23b2f861cd6dceb82f54a2685059b6 Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Thu, 14 Sep 2023 09:09:29 +
Subject: [PATCH 1/2] [flang] Enable alias tags pass by default
Enable by
@@ -242,10 +242,24 @@ static void
parseCodeGenArgs(Fortran::frontend::CodeGenOptions ,
clang::driver::options::OPT_fno_loop_versioning, false))
opts.LoopVersioning = 1;
- opts.AliasAnalysis =
-
29 matches
Mail list logo
