[clang] [libclang] Compute the right spelling location (PR #72400)

https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Compute the right spelling location (PR #72400)

sebastianpoeplau wrote: Thanks for the approval @jansvoboda11! Would you mind merging the change? I don't have the required permissions... https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [libclang] Compute the right spelling location (PR #72400)

https://github.com/jansvoboda11 approved this pull request. https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Compute the right spelling location (PR #72400)

@@ -1292,6 +1292,31 @@ void func() {} EXPECT_EQ(attrCount, 1); } +TEST_F(LibclangParseTest, clang_getSpellingLocation) { + std::string fileName = "main.c"; + WriteFile(fileName, "#define X(value) int x = value;\nX(42)\n"); + + ClangTU = clang_parseTranslationUnit(Index, f

[clang] [libclang] Compute the right spelling location (PR #72400)

https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From cc15f9bb8b37fb1b68bd33241ab37e98d57d274c Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati

[clang] [libclang] Compute the right spelling location (PR #72400)

@@ -1292,6 +1292,31 @@ void func() {} EXPECT_EQ(attrCount, 1); } +TEST_F(LibclangParseTest, clang_getSpellingLocation) { + std::string fileName = "main.c"; + WriteFile(fileName, "#define X(value) int x = value;\nX(42)\n"); + + ClangTU = clang_parseTranslationUnit(Index, f

[clang] [libclang] Compute the right spelling location (PR #72400)

sebastianpoeplau wrote: Thanks for the review @jansvoboda11; I've added an entry in the release notes and a unit test. https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [libclang] Compute the right spelling location (PR #72400)

https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From dd0f87b25733b4569b89ce445630ee843e3bfb2b Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati

[clang] [libclang] Compute the right spelling location (PR #72400)

jansvoboda11 wrote: The change itself looks good, but I think we should have a test and an entry in release notes. https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [libclang] Compute the right spelling location (PR #72400)

sebastianpoeplau wrote: @jansvoboda11 since you've most recently touched this part of the code, would you mind having a look at the change? https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [libclang] Compute the right spelling location (PR #72400)

https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From f260093f23fe599f2b91bbe0bf06304387549a22 Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati

[clang] [libclang] Compute the right spelling location (PR #72400)

sebastianpoeplau wrote: Ping https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Compute the right spelling location (PR #72400)

sebastianpoeplau wrote: I just discovered #28205 which should be fixed by this change. https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Compute the right spelling location (PR #72400)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ac378ac493426f8094cfaa176f1e88b62914f630 88b94c936257100e5400ad37273bb9d509ecfe3c --

[clang] [libclang] Compute the right spelling location (PR #72400)

https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From db1f8becea210494ae42619cba3ad697cddc07bf Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati

[clang] [libclang] Compute the right spelling location (PR #72400)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Sebastian Poeplau (sebastianpoeplau) Changes Locations inside macro expansions have different spelling/expansion locations. Apply a FIXME to make the libclang function clang_getSpellingLocation return the right spelling location, and adap

[clang] [libclang] Compute the right spelling location (PR #72400)

https://github.com/sebastianpoeplau created https://github.com/llvm/llvm-project/pull/72400 Locations inside macro expansions have different spelling/expansion locations. Apply a FIXME to make the libclang function clang_getSpellingLocation return the right spelling location, and adapt the tes