erichkeane wrote:
> Is there something else needed on my side to get that PR merged?
My apologies, I thought you'd been around LLVM enough that you had merge
rights. I've done it now.
https://github.com/llvm/llvm-project/pull/92126
___
cfe-commits
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/92126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjodinchr wrote:
Is there something else needed on my side to get that PR merged?
https://github.com/llvm/llvm-project/pull/92126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
Still fine once CI approves
https://github.com/llvm/llvm-project/pull/92126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rjodinchr updated
https://github.com/llvm/llvm-project/pull/92126
>From c8798839ee93caa9e5a3db6d770801a4c22010c8 Mon Sep 17 00:00:00 2001
From: Romaric Jodin
Date: Tue, 14 May 2024 16:08:26 +0200
Subject: [PATCH] libclc: remove __attribute__((assume)) for clspv targets
Sirraide wrote:
There’s a test that checks all attributes that we support
(Misc/pragma-attribute-supported-attributes-list.test) and which is failing at
the moment; you’ll have to add this attribute there as well.
https://github.com/llvm/llvm-project/pull/92126
https://github.com/rjodinchr updated
https://github.com/llvm/llvm-project/pull/92126
>From 4ce295d3dbd7a5b723cdf410d2023eb59120d27a Mon Sep 17 00:00:00 2001
From: Romaric Jodin
Date: Tue, 14 May 2024 16:08:26 +0200
Subject: [PATCH] libclc: remove __attribute__((assume)) for clspv targets
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/92126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rjodinchr updated
https://github.com/llvm/llvm-project/pull/92126
>From df793384bdb689b3b74ca83102a539a1db623e9f Mon Sep 17 00:00:00 2001
From: Romaric Jodin
Date: Tue, 14 May 2024 16:08:26 +0200
Subject: [PATCH] libclc: remove __attribute__((assume)) for clspv targets
@@ -393,6 +393,8 @@ Attribute Changes in Clang
- Clang now warns that the ``exclude_from_explicit_instantiation`` attribute
is ignored when applied to a local class or a member thereof.
+- The ``clspv_libclc_builtin`` attribute has been added to allow clspv to
identified
@@ -8087,3 +8087,10 @@ requirement:
}
}];
}
+
+def ClspvLibclcBuiltinDoc : Documentation {
+ let Category = DocCatFunction;
+ let Content = [{
+Attribute used by clspv to identified functions coming from libclc.
erichkeane wrote:
I think this needs
https://github.com/rjodinchr updated
https://github.com/llvm/llvm-project/pull/92126
>From 05fd8c24146a5237c7c4cc425beb205524429ba7 Mon Sep 17 00:00:00 2001
From: Romaric Jodin
Date: Tue, 14 May 2024 16:08:26 +0200
Subject: [PATCH] libclc: remove __attribute__((assume)) for clspv targets
erichkeane wrote:
> @erichkeane, I don't know what you expect for the release note, where should
> I write something?
See `ReleaseNotes.rst`, find a section that makes sense (probably attribute
changes), and write a quick blurb about the attribute, likely a very condensed
version of the
rjodinchr wrote:
@erichkeane, I don't know what you expect for the release note, where should I
write something?
https://github.com/llvm/llvm-project/pull/92126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -4561,3 +4561,9 @@ def CodeAlign: StmtAttr {
static constexpr int MaximumAlignment = 4096;
}];
}
+
+def ClspvLibclcBuiltin: DeclOrStmtAttr {
+ let Spellings = [Clang<"clspv_libclc_builtin">];
+ let Documentation = [Undocumented];
erichkeane wrote:
@@ -4561,3 +4561,9 @@ def CodeAlign: StmtAttr {
static constexpr int MaximumAlignment = 4096;
}];
}
+
+def ClspvLibclcBuiltin: DeclOrStmtAttr {
+ let Spellings = [Clang<"clspv_libclc_builtin">];
+ let Documentation = [Undocumented];
rjodinchr wrote:
@@ -4561,3 +4561,9 @@ def CodeAlign: StmtAttr {
static constexpr int MaximumAlignment = 4096;
}];
}
+
+def ClspvLibclcBuiltin: DeclOrStmtAttr {
+ let Spellings = [Clang<"clspv_libclc_builtin">];
+ let Documentation = [Undocumented];
+ let SimpleHandler = 1;
@@ -4561,3 +4561,9 @@ def CodeAlign: StmtAttr {
static constexpr int MaximumAlignment = 4096;
}];
}
+
+def ClspvLibclcBuiltin: DeclOrStmtAttr {
+ let Spellings = [Clang<"clspv_libclc_builtin">];
+ let Documentation = [Undocumented];
+ let SimpleHandler = 1;
@@ -4561,3 +4561,9 @@ def CodeAlign: StmtAttr {
static constexpr int MaximumAlignment = 4096;
}];
}
+
+def ClspvLibclcBuiltin: DeclOrStmtAttr {
+ let Spellings = [Clang<"clspv_libclc_builtin">];
+ let Documentation = [Undocumented];
erichkeane wrote:
@@ -4561,3 +4561,9 @@ def CodeAlign: StmtAttr {
static constexpr int MaximumAlignment = 4096;
}];
}
+
+def ClspvLibclcBuiltin: DeclOrStmtAttr {
+ let Spellings = [Clang<"clspv_libclc_builtin">];
+ let Documentation = [Undocumented];
+ let SimpleHandler = 1;
https://github.com/erichkeane commented:
Also needs:
-a release note
-A test: At least a test against LLVM-IR (CodeGen test).
https://github.com/llvm/llvm-project/pull/92126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/92126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rjodinchr updated
https://github.com/llvm/llvm-project/pull/92126
>From 41e2a5c3fd693fad20e2f76d1a39a1ac9468a33b Mon Sep 17 00:00:00 2001
From: Romaric Jodin
Date: Tue, 14 May 2024 16:08:26 +0200
Subject: [PATCH] libclc: remove __attribute__((assume)) for clspv targets
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 041baf2f60ac3e107399641aea04c77019e7eab8
4dc2646a51a05abe7cfb539325dbd57d507dfceb --
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang
Author: Romaric Jodin (rjodinchr)
Changes
Instead add a proper attribute in clang, and add convert it to function
metadata to keep the information in the IR. The goal is to remove the
dependency on
https://github.com/rjodinchr created
https://github.com/llvm/llvm-project/pull/92126
Instead add a proper attribute in clang, and add convert it to function
metadata to keep the information in the IR. The goal is to remove the
dependency on __attribute__((assume)) that should have not be
26 matches
Mail list logo
