mizvekov wrote:
> so after this patch, clang seems to be crashing on:
Thanks for the reproducer. Yeah this is about default argument deduction, which
doesn't involve default arguments as written in source.
I confirm the crash and it's indeed caused by changes in this patch. The fix is
very
kadircet wrote:
so after this patch, clang seems to be crashing on:
```cpp
template struct map {};
template class foo {};
template class MapType, typename Value>
Value bar(MapType map);
template class MapType, typename Value>
Value bar(MapType> map);
void aux() {
map> input;
pcc wrote:
> @pcc #93926 should fix it, can you double check that it gets all issues?
Yes, the bot is green now, thanks.
https://github.com/llvm/llvm-project/pull/93433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mizvekov wrote:
@pcc https://github.com/llvm/llvm-project/pull/93926 should fix it, can you
double check that it gets all issues?
https://github.com/llvm/llvm-project/pull/93433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcc wrote:
This commit broke the UBSan buildbot:
https://lab.llvm.org/buildbot/#/builders/85/builds/24378
Can you please take a look?
https://github.com/llvm/llvm-project/pull/93433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mizvekov wrote:
> Could you please take another look?
Sure, but let's take the discussion to the other PR.
https://github.com/llvm/llvm-project/pull/93433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jcsxky wrote:
@mizvekov After I apply you changes in this patch,
https://github.com/llvm/llvm-project/issues/91677 is still crash(although it
makes sense with `-ast-dump` option). I put it below for explanation clearly:
```cpp
template struct t1 {
template
struct t2 {};
};
template
mizvekov wrote:
@nikic Thanks for the heads-up. I expected some impact. There are some ideas to
regain that loss in follow up work.
https://github.com/llvm/llvm-project/pull/93433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nikic wrote:
This change seems to have some compile-time overhead. I'm not seeing a lot on
CTMark, but during the clang bootstrap there are many files with ~1%
regressions
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/93433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1a2f3309765fdc143fdc3809211fb85d2e2ca341
8322ce12520d1d4ab96b58195bd91f62a7b95c06 --
https://github.com/kazutakahirata updated
https://github.com/llvm/llvm-project/pull/93433
>From 8322ce12520d1d4ab96b58195bd91f62a7b95c06 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sat, 25 May 2024 13:57:39 -0300
Subject: [PATCH] [clang] Preserve Qualifiers and type sugar in
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/93433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
13 matches
Mail list logo
