paulwalker-arm wrote:
@momchil-velikov's commentary applies globally and is not specific to FPMR.
Which is to say, Arm switched a while back from "all system register need to be
protected by their feature flag" to "only protect system registers where there
is a need". The rational is that we
ahmedbougacha wrote:
> The overall idea is that system registers ought be available everywhere
> without the need to explicitly enable them with a command line option.
Interesting, that's kind of what I'm getting at: longer term, are you saying
you folks are considering removing the feature
momchil-velikov wrote:
> > This patch removes FEAT_FPMR from list of available of architecture
> > features, instead enabling FMPR register by default.
>
> Can you expand a little bit on the reasoning? It doesn't seem all that
> problematic but is still eyebrow-raising.
The overall idea is
ahmedbougacha wrote:
> This patch removes FEAT_FPMR from list of available of architecture features,
> instead enabling FMPR register by default.
Can you expand a little bit on the reasoning? It doesn't seem all that
problematic but is still eyebrow-raising.
https://github.com/Lukacma closed
https://github.com/llvm/llvm-project/pull/90612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tmatheson-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/90612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1996,7 +1996,6 @@ TEST(TargetParserTest, AArch64ExtensionFeatures) {
AArch64::AEK_D128, AArch64::AEK_LSE128,
AArch64::AEK_SPECRES2, AArch64::AEK_RASv2,
AArch64::AEK_ITE, AArch64::AEK_GCS,
- AArch64::AEK_FPMR,
@@ -1942,12 +1942,10 @@ def : RWSysReg<"PM",0b11, 0b000,
0b0100, 0b0011, 0b001>;
// 2023 ISA Extension
// AArch64 Floating-point Mode Register controls behaviors of the FP8
-// instructions (FEAT_FPMR)
Lukacma wrote:
Done
https://github.com/Lukacma updated
https://github.com/llvm/llvm-project/pull/90612
>From 2f8d7a5898697529d07bef72181510af105327e9 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Tue, 21 May 2024 11:21:18 +
Subject: [PATCH] [AArch64] Fix feature flags dependecies
---
https://github.com/Lukacma updated
https://github.com/llvm/llvm-project/pull/90612
>From a68d74949438f486f8443c1a4cb5727d769dde31 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Fri, 26 Apr 2024 09:58:44 +
Subject: [PATCH 1/4] [AArch64] Fix feature flags dependecies
---
@@ -22,6 +22,14 @@
// RUN: %clang -target aarch64 -march=armv9.5-a+cpa -### -c %s 2>&1 |
FileCheck -check-prefix=V95A-CPA %s
// V95A-CPA: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-cpu" "generic"
"-target-feature" "+v9.5a"{{.*}} "-target-feature" "+cpa"
+// RUN: %clang
https://github.com/tmatheson-arm edited
https://github.com/llvm/llvm-project/pull/90612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1996,7 +1996,6 @@ TEST(TargetParserTest, AArch64ExtensionFeatures) {
AArch64::AEK_D128, AArch64::AEK_LSE128,
AArch64::AEK_SPECRES2, AArch64::AEK_RASv2,
AArch64::AEK_ITE, AArch64::AEK_GCS,
- AArch64::AEK_FPMR,
@@ -1942,12 +1942,10 @@ def : RWSysReg<"PM",0b11, 0b000,
0b0100, 0b0011, 0b001>;
// 2023 ISA Extension
// AArch64 Floating-point Mode Register controls behaviors of the FP8
-// instructions (FEAT_FPMR)
tmatheson-arm wrote:
The comment
https://github.com/tmatheson-arm edited
https://github.com/llvm/llvm-project/pull/90612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -22,6 +22,14 @@
// RUN: %clang -target aarch64 -march=armv9.5-a+cpa -### -c %s 2>&1 |
FileCheck -check-prefix=V95A-CPA %s
// V95A-CPA: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-cpu" "generic"
"-target-feature" "+v9.5a"{{.*}} "-target-feature" "+cpa"
+// RUN: %clang
https://github.com/tmatheson-arm commented:
This might need reworked since I landed
https://github.com/llvm/llvm-project/pull/90987.. Ping me internally if I can
help.
https://github.com/llvm/llvm-project/pull/90612
___
cfe-commits mailing list
@@ -291,18 +290,17 @@ inline constexpr ExtensionInfo Extensions[] = {
{"tme", AArch64::AEK_TME, "+tme", "-tme", FEAT_INIT, "", 0},
{"wfxt", AArch64::AEK_NONE, {}, {}, FEAT_WFXT, "+wfxt", 550},
{"gcs", AArch64::AEK_GCS, "+gcs", "-gcs", FEAT_INIT, "", 0},
-
https://github.com/Lukacma updated
https://github.com/llvm/llvm-project/pull/90612
>From a68d74949438f486f8443c1a4cb5727d769dde31 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Fri, 26 Apr 2024 09:58:44 +
Subject: [PATCH 1/5] [AArch64] Fix feature flags dependecies
---
https://github.com/Lukacma updated
https://github.com/llvm/llvm-project/pull/90612
>From a68d74949438f486f8443c1a4cb5727d769dde31 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Fri, 26 Apr 2024 09:58:44 +
Subject: [PATCH 1/4] [AArch64] Fix feature flags dependecies
---
@@ -291,18 +290,17 @@ inline constexpr ExtensionInfo Extensions[] = {
{"tme", AArch64::AEK_TME, "+tme", "-tme", FEAT_INIT, "", 0},
{"wfxt", AArch64::AEK_NONE, {}, {}, FEAT_WFXT, "+wfxt", 550},
{"gcs", AArch64::AEK_GCS, "+gcs", "-gcs", FEAT_INIT, "", 0},
-
@@ -291,15 +290,14 @@ inline constexpr ExtensionInfo Extensions[] = {
{"tme", AArch64::AEK_TME, "+tme", "-tme", FEAT_INIT, "", 0},
{"wfxt", AArch64::AEK_NONE, {}, {}, FEAT_WFXT, "+wfxt", 550},
{"gcs", AArch64::AEK_GCS, "+gcs", "-gcs", FEAT_INIT, "", 0},
-
@@ -3731,7 +3730,7 @@ static const struct Extension {
{"sme-lutv2", {AArch64::FeatureSME_LUTv2}},
{"sme-f8f16", {AArch64::FeatureSMEF8F16}},
{"sme-f8f32", {AArch64::FeatureSMEF8F32}},
-{"sme-fa64", {AArch64::FeatureSMEFA64}},
+{"sme-fa64",
https://github.com/Lukacma updated
https://github.com/llvm/llvm-project/pull/90612
>From a68d74949438f486f8443c1a4cb5727d769dde31 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Fri, 26 Apr 2024 09:58:44 +
Subject: [PATCH 1/3] [AArch64] Fix feature flags dependecies
---
https://github.com/Lukacma updated
https://github.com/llvm/llvm-project/pull/90612
>From a68d74949438f486f8443c1a4cb5727d769dde31 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Fri, 26 Apr 2024 09:58:44 +
Subject: [PATCH 1/2] [AArch64] Fix feature flags dependecies
---
@@ -291,15 +290,14 @@ inline constexpr ExtensionInfo Extensions[] = {
{"tme", AArch64::AEK_TME, "+tme", "-tme", FEAT_INIT, "", 0},
{"wfxt", AArch64::AEK_NONE, {}, {}, FEAT_WFXT, "+wfxt", 550},
{"gcs", AArch64::AEK_GCS, "+gcs", "-gcs", FEAT_INIT, "", 0},
-
@@ -3731,7 +3730,7 @@ static const struct Extension {
{"sme-lutv2", {AArch64::FeatureSME_LUTv2}},
{"sme-f8f16", {AArch64::FeatureSMEF8F16}},
{"sme-f8f32", {AArch64::FeatureSMEF8F32}},
-{"sme-fa64", {AArch64::FeatureSMEFA64}},
+{"sme-fa64",
https://github.com/Lukacma updated
https://github.com/llvm/llvm-project/pull/90612
>From a68d74949438f486f8443c1a4cb5727d769dde31 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Fri, 26 Apr 2024 09:58:44 +
Subject: [PATCH] [AArch64] Fix feature flags dependecies
---
llvmbot wrote:
@llvm/pr-subscribers-mc
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: None (Lukacma)
Changes
This patch removes FEAT_FPMR from list of available of architecture features,
instead enabling FMPR register by default.
Additionally dependencies between
https://github.com/Lukacma created
https://github.com/llvm/llvm-project/pull/90612
This patch removes FEAT_FPMR from list of available of architecture features,
instead enabling FMPR register by default.
Additionally dependencies between architectural features are added and fixed.
>From
30 matches
Mail list logo
