arsenm wrote:
Replaced by #108596
https://github.com/llvm/llvm-project/pull/92809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/92809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alex-t wrote:
> @alex-t Just curious about the status of this PR. Both this PR and the
> register-allocation PR by CD will have significant impact to the generated
> code. If we decide this is the right direction, then I feel it would be
> better to get it in earlier, so we can access its impa
cmc-rep wrote:
@alex-t Just curious about the status of this PR. Both this PR and the
register-allocation PR by CD will have significant impact to the generated
code. If we decide this is the right direction, then I feel it would be better
to get it in earlier, so we can access its impact in
@@ -3172,8 +3172,8 @@ def int_amdgcn_loop : Intrinsic<[llvm_i1_ty],
[llvm_anyint_ty], [IntrWillReturn, IntrNoCallback, IntrNoFree]
>;
-def int_amdgcn_end_cf : Intrinsic<[], [llvm_anyint_ty],
- [IntrWillReturn, IntrNoCallback, IntrNoFree]>;
+def int_amdgcn_wave_reconverge :
@@ -305,43 +304,43 @@ bool SIAnnotateControlFlow::handleLoop(BranchInst *Term) {
}
/// Close the last opened control flow
-bool SIAnnotateControlFlow::closeControlFlow(BasicBlock *BB) {
- llvm::Loop *L = LI->getLoopFor(BB);
+bool SIAnnotateControlFlow::tryWaveReconverge(Basic
@@ -305,43 +304,43 @@ bool SIAnnotateControlFlow::handleLoop(BranchInst *Term) {
}
/// Close the last opened control flow
-bool SIAnnotateControlFlow::closeControlFlow(BasicBlock *BB) {
- llvm::Loop *L = LI->getLoopFor(BB);
+bool SIAnnotateControlFlow::tryWaveReconverge(Basic
@@ -0,0 +1 @@
+remark: :0:0: removing function 'needs_extimg': +extended-image-insts
is not supported on the current target
arsenm wrote:
accidentally added file?
https://github.com/llvm/llvm-project/pull/92809
___
c
@@ -15740,6 +15740,32 @@ void
SITargetLowering::finalizeLowering(MachineFunction &MF) const {
}
}
+ // ISel inserts copy to regs for the successor PHIs
+ // at the BB end. We need to move the SI_WAVE_RECONVERGE right before the
arsenm wrote:
Can you
@@ -2103,12 +2103,36 @@ bool SIInstrInfo::expandPostRAPseudo(MachineInstr &MI)
const {
MI.setDesc(get(AMDGPU::S_MOV_B64));
break;
+ case AMDGPU::S_CMOV_B64_term:
+// This is only a terminator to get the correct spill code placement during
+// register allocat
@@ -1,3 +1,4 @@
+; XFAIL: *
arsenm wrote:
can't just xfail tests
https://github.com/llvm/llvm-project/pull/92809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -3172,8 +3172,8 @@ def int_amdgcn_loop : Intrinsic<[llvm_i1_ty],
[llvm_anyint_ty], [IntrWillReturn, IntrNoCallback, IntrNoFree]
>;
-def int_amdgcn_end_cf : Intrinsic<[], [llvm_anyint_ty],
- [IntrWillReturn, IntrNoCallback, IntrNoFree]>;
+def int_amdgcn_wave_reconverge :
@@ -15740,6 +15740,32 @@ void
SITargetLowering::finalizeLowering(MachineFunction &MF) const {
}
}
+ // ISel inserts copy to regs for the successor PHIs
+ // at the BB end. We need to move the SI_WAVE_RECONVERGE right before the
+ // branch.
+ for (auto &MBB : MF) {
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/92809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm requested changes to this pull request.
There are quite a few code quality regressions, and XFAILed tests. The
description needs more elaboration on what the strategy is here
https://github.com/llvm/llvm-project/pull/92809
_
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 586ecd75606e70a8d16cb1717809acce652ffe7f
7cda2e3ce0d180688250856566b6c75ca07d7711 --
llvmbot wrote:
@llvm/pr-subscribers-llvm-globalisel
Author: None (alex-t)
Changes
We currently lower the SI_IF/ELSE, SI_LOOP, and SI_END_CF to reconverge the
wave at the beginning of the CF join basic block or on the loop exit block.
This leads to numerous issues related to the spill/spl
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (alex-t)
Changes
We currently lower the SI_IF/ELSE, SI_LOOP, and SI_END_CF to reconverge the
wave at the beginning of the CF join basic block or on the loop exit block.
This leads to numerous issues related to the spill/split inserti
18 matches
Mail list logo
