[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Ben Shi via cfe-commits
https://github.com/benshi001 closed https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Ben Shi via cfe-commits
https://github.com/benshi001 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Ben Shi via cfe-commits
benshi001 wrote: > For future reference, the avr16/avr32 devices do have SPM and SPMX features, > but the current xmega3 definition has not. > > Xmega3 is also used for modern attiny series which do not have SPM(X), so > that is correct. > > The avr64 devices use xmega2 which has SPM(X) defin

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Ben Shi via cfe-commits
benshi001 wrote: > @tomtor @benshi001 I just tried your latest revision on the top of tree, and > both `check-llvm` and `check-clang` passed. Thanks for your help ! https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-com

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: @tomtor @benshi001 I just tried your latest revision on the top of tree, and both `check-llvm` and `check-clang` passed. https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Tom Vijlbrief via cfe-commits
tomtor wrote: For future reference, the avr16/avr32 devices do have SPM and SPMX features, but the current xmega3 definition has not. Xmega3 is also used for modern attiny series which do not have SPM(X), so that is correct. The avr64 devices use xmega2 which has SPM(X) defined, so that is al

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Tom Vijlbrief via cfe-commits
https://github.com/tomtor updated https://github.com/llvm/llvm-project/pull/144229 >From 57a30b4bfd87a8389ab042b2c9184a59bf7f4519 Mon Sep 17 00:00:00 2001 From: Tom Vijlbrief Date: Thu, 12 Jun 2025 16:59:46 +0200 Subject: [PATCH 1/9] Add support for many new AVR mcus like AVR128DB28 --- clang

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Tom Vijlbrief via cfe-commits
tomtor wrote: Double checking https://onlinedocs.microchip.com/oxy/GUID-0B644D8F-67E7-49E6-82C9-1B2B9ABE6A0D-en-US-23/GUID-33953345-30E8-49BC-89A0-9734DC6EA5B9.html https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-comm

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Tom Vijlbrief via cfe-commits
https://github.com/tomtor updated https://github.com/llvm/llvm-project/pull/144229 >From 57a30b4bfd87a8389ab042b2c9184a59bf7f4519 Mon Sep 17 00:00:00 2001 From: Tom Vijlbrief Date: Thu, 12 Jun 2025 16:59:46 +0200 Subject: [PATCH 1/8] Add support for many new AVR mcus like AVR128DB28 --- clang

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Ben Shi via cfe-commits
benshi001 wrote: > manage to run these tests locally yet, but will figure that out. This flang failure did not relate to your AVR patch, just omit it. https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Tom Vijlbrief via cfe-commits
tomtor wrote: In the CI check I find one ` FAIL:` ``` 2025-06-15T07:21:48.1250696Z FAIL: Flang :: Semantics/modfile76.F90 (3383 of 3529) 2025-06-15T07:21:48.1251772Z TEST 'Flang :: Semantics/modfile76.F90' FAILED ``` but this is unrelated? (Flang, for

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Tom Vijlbrief via cfe-commits
tomtor wrote: @kazutakahirata Thanks again! I noticed the failling check but could not find the cause in the enormous log file. Wondered if it could be caused by a timeout on the build, but it was this failing check. Added new test patterns for the new MCUs. Did not manage to run these tests

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-15 Thread Tom Vijlbrief via cfe-commits
https://github.com/tomtor updated https://github.com/llvm/llvm-project/pull/144229 >From 57a30b4bfd87a8389ab042b2c9184a59bf7f4519 Mon Sep 17 00:00:00 2001 From: Tom Vijlbrief Date: Thu, 12 Jun 2025 16:59:46 +0200 Subject: [PATCH 1/7] Add support for many new AVR mcus like AVR128DB28 --- clang

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: @tomtor https://github.com/llvm/llvm-project/actions/runs/15653757180/job/44101995731?pr=144229 is showing: ``` /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Misc/target-invalid-cpu-note/avr.c:314:16: error: CHECK-SAME: expected string not found in

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread Tom Vijlbrief via cfe-commits
tomtor wrote: My local tree build OK... https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread Tom Vijlbrief via cfe-commits
tomtor wrote: > LGTM. Thank you for updating the patch! Thanks! I am now rebuilding after: `cmake -S llvm -B build -G Ninja` https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata approved this pull request. LGTM. Thank you for updating the patch! https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: @tomtor > my local compile did compile my files, but ended with: > > ``` > cc1plus: fatal error: > /home/tom/src/rust/llvm-project/llvm/lib/DebugInfo/LogicalView/Core/LVSourceLanguage.cpp: > No such file or > directory > compilation terminated. > [1758/5167] Building CX

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread Tom Vijlbrief via cfe-commits
tomtor wrote: @Patryk27 @benshi001 @kazutakahirata Oops, as you noticed I did not recompile after adding the avr64* models. Sorry for that, changes are almost never trivial Hope all is ok now, my local compile did compile my files, but ended with: cc1plus: fatal error: /home/tom/src/rust

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread Tom Vijlbrief via cfe-commits
https://github.com/tomtor edited https://github.com/llvm/llvm-project/pull/144229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Tom Vijlbrief (tomtor) Changes https://github.com/llvm/llvm-project/pull/143914 failed to compile due to an unchecked late change. Sorry for that. Added the missing XMEGA2 definition. --- Full diff: https://github.com/llvm/llvm-

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Vijlbrief (tomtor) Changes https://github.com/llvm/llvm-project/pull/143914 failed to compile due to an unchecked late change. Sorry for that. Added the missing XMEGA2 definition. --- Full diff: https://github.com/llvm/llvm-project

[clang] [llvm] [AVR] Add many new AVR MCU model definitions (PR #144229)

2025-06-14 Thread Tom Vijlbrief via cfe-commits
https://github.com/tomtor created https://github.com/llvm/llvm-project/pull/144229 https://github.com/llvm/llvm-project/pull/143914 failed to compile due to an unchecked late change. Sorry for that. Added the missing XMEGA2 definition. >From 57a30b4bfd87a8389ab042b2c9184a59bf7f4519 Mon Sep