[clang] [llvm] [CodeGen][AArch64] Added -mno-va-float to skip FP save in variadic functions (PR #92827)

2024-05-20 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: This patch, as proposed, doesn't seem like a good idea: it's very likely to miscompile user code without any diagnostic. Are you sure you don't want one of the following? - A soft-float ABI (-mabi=aapcs-soft) - Completely forbidding the use of floating-point values

[clang] [llvm] [CodeGen][AArch64] Added -mno-va-float to skip FP save in variadic functions (PR #92827)

2024-05-20 Thread Jon Chesterfield via cfe-commits
JonChesterfield wrote: Aarch64 has a dedicated floating point region in the va_list structure. Is the intent of this patch to globally disable the use of that, such that clang should arrange to put floating point values in the stack fallback area instead?

[clang] [llvm] [CodeGen][AArch64] Added -mno-va-float to skip FP save in variadic functions (PR #92827)

2024-05-20 Thread Laurentiu Tertan via cfe-commits
ltertan wrote: @TNorthover The PR mentions no Reviewers, so I'm adding you. Please help me redirect this if you're not the right person to review this. Thanks! https://github.com/llvm/llvm-project/pull/92827 ___ cfe-commits mailing list

[clang] [llvm] [CodeGen][AArch64] Added -mno-va-float to skip FP save in variadic functions (PR #92827)

2024-05-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-clang-driver Author: Laurentiu Tertan (ltertan) Changes This patch adds a new option for AArch64, -mno-va-float which can be used to disable the generation of code that saves FP in variadic functions --- Full diff:

[clang] [llvm] [CodeGen][AArch64] Added -mno-va-float to skip FP save in variadic functions (PR #92827)

2024-05-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Laurentiu Tertan (ltertan) Changes This patch adds a new option for AArch64, -mno-va-float which can be used to disable the generation of code that saves FP in variadic functions --- Full diff:

[clang] [llvm] [CodeGen][AArch64] Added -mno-va-float to skip FP save in variadic functions (PR #92827)

2024-05-20 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [llvm] [CodeGen][AArch64] Added -mno-va-float to skip FP save in variadic functions (PR #92827)

2024-05-20 Thread Laurentiu Tertan via cfe-commits
https://github.com/ltertan created https://github.com/llvm/llvm-project/pull/92827 This patch adds a new option for AArch64, -mno-va-float which can be used to disable the generation of code that saves FP in variadic functions >From 3d6a1b5d0bfff6b7ffb444a3fb6a32ea0faceea8 Mon Sep 17 00:00:00