agozillon wrote:
Just landed the PR, so it should be good to land this PR now without causing
issues with the flang+openmp+offload buildbot, however, if any other issues do
arise, I am happy to look into them! But from testing this PR in conjunction
with the one I just landed locally, it does
agozillon wrote:
@nikic sounds good, if that changes don't hesitate to ping me and I'll be happy
to deactivate the tests for a while (or feel free to do so yourself, just ping
to tell me they're off so I know to turn them on again when the PR lands!)
nikic wrote:
@agozillon Thanks for looking into this! This change isn't urgent, so I'm happy
to wait for your PR to go in first.
https://github.com/llvm/llvm-project/pull/95126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
agozillon wrote:
Hey, @jplehr notified me of this issue (thank you), I've had a little look at
it and it's related to an issue this PR fixes:
https://github.com/llvm/llvm-project/pull/94541 which you are currently a
reviewer of ironically (as I use and alter slightly a piece of functionality
jplehr wrote:
Thank you @nikic.
I'll see to reproduce locally and narrow down as much as possible to provide
small reproducer.
https://github.com/llvm/llvm-project/pull/95126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nikic wrote:
> I believe this broke our flang+openmp+offload bot:
> https://lab.llvm.org/staging/#/builders/140/builds/10168 Happy to help
> looking into it.
That's for the heads-up, I've reverted this patch in
jplehr wrote:
I believe this broke our flang+openmp+offload bot:
https://lab.llvm.org/staging/#/builders/140/builds/10168
Happy to help looking into it.
https://github.com/llvm/llvm-project/pull/95126
___
cfe-commits mailing list
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/95126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtcxzyw approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/95126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nikic wrote:
> See
> [51e459a](https://github.com/llvm/llvm-project/commit/51e459a561519c8d51e2b4cadddc0d1f99c8b7ef):
>
> > This causes some non-trivial text size increases in unoptimized builds for
> > Bullet. Revert while I investigate.
>
> Can you double check this?
This was mitigated by
https://github.com/aeubanks approved this pull request.
https://github.com/llvm/llvm-project/pull/95126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtcxzyw wrote:
See
https://github.com/llvm/llvm-project/commit/51e459a561519c8d51e2b4cadddc0d1f99c8b7ef:
> This causes some non-trivial text size increases in unoptimized builds for
> Bullet. Revert while I investigate.
Can you double check this?
llvmbot wrote:
@llvm/pr-subscribers-llvm-analysis
Author: Nikita Popov (nikic)
Changes
This is a followup to https://github.com/llvm/llvm-project/pull/93823 and drops
the DataLayout-unaware GEP of GEP fold entirely. All cases are now left to the
DataLayout-aware constant folder, which
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
Author: Nikita Popov (nikic)
Changes
This is a followup to https://github.com/llvm/llvm-project/pull/93823 and drops
the DataLayout-unaware GEP of GEP fold entirely. All cases are now left to the
DataLayout-aware constant folder, which will
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nikita Popov (nikic)
Changes
This is a followup to https://github.com/llvm/llvm-project/pull/93823 and drops
the DataLayout-unaware GEP of GEP fold entirely. All cases are now left to the
DataLayout-aware constant folder, which will fold
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/95126
This is a followup to https://github.com/llvm/llvm-project/pull/93823 and drops
the DataLayout-unaware GEP of GEP fold entirely. All cases are now left to the
DataLayout-aware constant folder, which will fold
16 matches
Mail list logo
