https://github.com/yxsamliu closed
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/83605
>From c46a3ce625a34a497cd0b14631cb755b903e93d6 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Fri, 1 Mar 2024 13:16:45 -0500
Subject: [PATCH] [HIP] add --offload-compression-level= option
Added
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/83605
>From 906b23c5f8ef815b7727fe2bda852c33f0d9147b Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Fri, 1 Mar 2024 13:16:45 -0500
Subject: [PATCH] [HIP] add --offload-compression-level= option
Added
@@ -2863,3 +2863,18 @@ void tools::addOutlineAtomicsArgs(const Driver , const
ToolChain ,
CmdArgs.push_back("+outline-atomics");
}
}
+
+void tools::addOffloadCompressArgs(const llvm::opt::ArgList ,
+ llvm::opt::ArgStringList ) {
+ if
@@ -2863,3 +2863,18 @@ void tools::addOutlineAtomicsArgs(const Driver , const
ToolChain ,
CmdArgs.push_back("+outline-atomics");
}
}
+
+void tools::addOffloadCompressArgs(const llvm::opt::ArgList ,
+ llvm::opt::ArgStringList ) {
+ if
https://github.com/Artem-B approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B edited
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/83605
>From 78ad578a19d2a3585f20ab64d364a46a584ec035 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Fri, 1 Mar 2024 13:16:45 -0500
Subject: [PATCH] [HIP] add --offload-compression-level= option
Added
https://github.com/jhuber6 commented:
Looks fine to me, I'll wait a bit to see if Artem or Fangrui have anything to
add.
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yxsamliu wrote:
> Should an option like in #84337 be added for the new driver?
added the option to linker wrapper
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/83605
>From 60faf7f657fdcc00edfa0a1813d1e2746c341ef1 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Fri, 1 Mar 2024 13:16:45 -0500
Subject: [PATCH] [HIP] add --offload-compression-level= option
Added
yxsamliu wrote:
> > Should an option like in #84337 be added for the new driver?
>
> Yes please
Oh. I can add it
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yxsamliu wrote:
> Should an option like in #84337 be added for the new driver?
Yes please
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/yxsamliu edited
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
Should an option like in https://github.com/llvm/llvm-project/pull/84337 be
added for the new driver?
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yxsamliu wrote:
zstd developers suggest to enable long distance matching (LDM), i.e. the
`--long` option. I updated the PR with the change, and tested that it works
well for bundle entry sizes range from 1KB to 20MB, for both compression rate
and compression/decompression speed.
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/83605
>From 16796bc8eb3b32436903db4b689d4cb9cfc348d8 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Fri, 1 Mar 2024 13:16:45 -0500
Subject: [PATCH] [HIP] add --offload-compression-level= option
Added
@@ -906,6 +906,16 @@ CreateFileHandler(MemoryBuffer ,
}
OffloadBundlerConfig::OffloadBundlerConfig() {
+ if (llvm::compression::zstd::isAvailable()) {
+CompressionFormat = llvm::compression::Format::Zstd;
+// Use a high zstd compress level by default for better size
yxsamliu wrote:
> It may be worth asking on https://github.com/facebook/zstd/ . I am sure zstd
> maintainers are happy to see more adoption:)
Posted a question to zstd https://github.com/facebook/zstd/issues/3932
https://github.com/llvm/llvm-project/pull/83605
yxsamliu wrote:
Here is the size distribution of individual code object file (each code object
file is for one GPU arch, and a fat binary contains a bunch of code object
files, therefore the optimal compression parameter is mostly related to code
object file size ).
| Bin Size | Count |
https://github.com/Artem-B edited
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -906,6 +906,16 @@ CreateFileHandler(MemoryBuffer ,
}
OffloadBundlerConfig::OffloadBundlerConfig() {
+ if (llvm::compression::zstd::isAvailable()) {
+CompressionFormat = llvm::compression::Format::Zstd;
+// Use a high zstd compress level by default for better size
MaskRay wrote:
It may be worth asking on https://github.com/facebook/zstd/ . I am sure zstd
maintainers are happy to see more adoption:)
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dwblaikie wrote:
> level 20 is a sweet spot for both compression rate and compression time
I wonder how much this is overfitting for kernels of a particular size, though?
(is it making the window just large enough that there's some "memory" from one
kernel to the next - but a slightly larger
@@ -906,6 +906,16 @@ CreateFileHandler(MemoryBuffer ,
}
OffloadBundlerConfig::OffloadBundlerConfig() {
+ if (llvm::compression::zstd::isAvailable()) {
+CompressionFormat = llvm::compression::Format::Zstd;
+// Use a high zstd compress level by default for better size
@@ -942,20 +942,28 @@ CompressedOffloadBundle::compress(const
llvm::MemoryBuffer ,
Input.getBuffer().size());
llvm::compression::Format CompressionFormat;
+ int Level;
- if (llvm::compression::zstd::isAvailable())
+ if (llvm::compression::zstd::isAvailable()) {
https://github.com/yxsamliu edited
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yxsamliu edited
https://github.com/llvm/llvm-project/pull/83605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
28 matches
Mail list logo
