https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/83938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 01/14] first try
---
clang/include/clang/Driver/Options.td | 4
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 01/13] first try
---
clang/include/clang/Driver/Options.td | 4
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 01/12] first try
---
clang/include/clang/Driver/Options.td | 4
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 01/11] first try
---
clang/include/clang/Driver/Options.td | 4
@@ -753,6 +753,7 @@ def err_drv_hlsl_bad_shader_required_in_target : Error<
def err_drv_hlsl_bad_shader_unsupported : Error<
"%select{shader model|Vulkan environment|shader stage}0 '%1' in target '%2'
is invalid for HLSL code generation">;
+
llvm-beanz wrot
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/83938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz approved this pull request.
Two small nits with suggestions. Otherwise LGTM.
https://github.com/llvm/llvm-project/pull/83938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -8545,6 +8545,13 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 01/10] first try
---
clang/include/clang/Driver/Options.td | 4
@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
@@ -753,6 +753,9 @@ def err_drv_hlsl_bad_shader_required_in_target : Error<
def err_drv_hlsl_bad_shader_unsupported : Error<
"%select{shader model|Vulkan environment|shader stage}0 '%1' in target '%2'
is invalid for HLSL code generation">;
+def err_drv_hlsl_dxc_bad_argument
@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
https://github.com/llvm-beanz commented:
Minor suggestion about the diagnostic.
@MaskRay do you have any thoughts about a follow-up change to add a
`DriverOptions` structure so that we could use argument marshalling for driver
options?
https://github.com/llvm/llvm-project/pull/83938
_
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/83938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 1/7] first try
---
clang/include/clang/Driver/Options.td | 4 ++
@@ -0,0 +1,18 @@
+// RUN: %clang_dxc -T lib_6_4 -HV 2016 %s 2>&1 -### | FileCheck
-check-prefix=2016 %s
+// RUN: %clang_dxc -T lib_6_4 -HV 2017 %s 2>&1 -### | FileCheck
-check-prefix=2017 %s
+// RUN: %clang_dxc -T lib_6_4 /HV 2018 %s 2>&1 -### | FileCheck
-check-prefix=20
@@ -226,6 +226,7 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args,
StringRef BoundArch,
A->claim();
continue;
}
+
llvm-beanz wrote:
Unnecessary whitespace change.
https://github.com/llvm/llvm-project/pull/83938
_
@@ -139,6 +139,7 @@ struct LangStandard {
bool isOpenCL() const { return Flags & OpenCL; }
static Kind getLangKind(StringRef Name);
+ static Kind getHLSLLangKind(StringRef Name);
llvm-beanz wrote:
This either.
https://github.com/llvm/llvm-project/pull/8
@@ -753,6 +753,9 @@ def err_drv_hlsl_bad_shader_required_in_target : Error<
def err_drv_hlsl_bad_shader_unsupported : Error<
"%select{shader model|Vulkan environment|shader stage}0 '%1' in target '%2'
is invalid for HLSL code generation">;
+def err_drv_hlsl_dxc_bad_argument
@@ -8549,7 +8549,10 @@ def dxc_hlsl_version : Option<["/", "-"], "HV",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"HLSL Version">,
- NormalizedValues<["2016", "2017", "20
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 1/8] first try
---
clang/include/clang/Driver/Options.td | 4 ++
@@ -69,6 +69,16 @@ LangStandard::Kind LangStandard::getLangKind(StringRef Name)
{
.Default(lang_unspecified);
}
+LangStandard::Kind LangStandard::getHLSLLangKind(StringRef Name) {
+ return llvm::StringSwitch(Name)
+ .Case("2016", LangStandard::lang_hlsl2016)
+
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 1/7] first try
---
clang/include/clang/Driver/Options.td | 4 ++
@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
https://github.com/python3kgae approved this pull request.
https://github.com/llvm/llvm-project/pull/83938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -69,6 +69,21 @@ LangStandard::Kind LangStandard::getLangKind(StringRef Name)
{
.Default(lang_unspecified);
}
+LangStandard::Kind LangStandard::getHLSLLangKind(StringRef Name) {
+ if (Name == "2016")
python3kgae wrote:
Maybe a StringSwitch here.
@@ -226,6 +226,47 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args,
StringRef BoundArch,
A->claim();
continue;
}
+if (A->getOption().getID() == options::OPT_dxc_hlsl_version) {
+ // Translate -HV into -std for llvm
+ // depending on the
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 1/6] first try
---
clang/include/clang/Driver/Options.td | 4 ++
@@ -226,6 +226,47 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args,
StringRef BoundArch,
A->claim();
continue;
}
+if (A->getOption().getID() == options::OPT_dxc_hlsl_version) {
+ // Translate -HV into -std for llvm
+ // depending on the
@@ -226,6 +226,47 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args,
StringRef BoundArch,
A->claim();
continue;
}
+if (A->getOption().getID() == options::OPT_dxc_hlsl_version) {
+ // Translate -HV into -std for llvm
+ // depending on the
@@ -226,6 +226,47 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args,
StringRef BoundArch,
A->claim();
continue;
}
+if (A->getOption().getID() == options::OPT_dxc_hlsl_version) {
+ // Translate -HV into -std for llvm
+ // depending on the
@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E",
KIND_JOINED_OR_SEPARATE>,
Group,
Visibility<[DXCOption]>,
HelpText<"Entry point name">;
+def dxc_hlsl_version : Option<["/", "-"], "HV", KIN
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 1/5] first try
---
clang/include/clang/Driver/Options.td | 4 ++
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6325dd57318bc4640dded8f59cadd315aa8185ae
79f5172bc97fb2c8591d46198e8eee7beaa66786 --
@@ -226,6 +226,28 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args,
StringRef BoundArch,
A->claim();
continue;
}
+if (A->getOption().getID() == options::OPT_dxc_hlsl_version) {
+ // Translate -HV into -std for llvm
+ // depending on the
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/83938
>From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Mar 2024 13:42:02 -0800
Subject: [PATCH 1/4] first try
---
clang/include/clang/Driver/Options.td | 4 ++
42 matches
Mail list logo
