[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-31 Thread via cfe-commits
gulfemsavrun wrote: > > > @gulfemsavrun Commit > > > [245491a](https://github.com/llvm/llvm-project/commit/245491a9f384e4c53421196533c2a2b693efaf8d) > > > (`[MC] Disable MCAssembler based constant folding for DwarfDebug`; > > > independent of this patch) should have fixed the compile time regr

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-31 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > @gulfemsavrun Commit > > [245491a](https://github.com/llvm/llvm-project/commit/245491a9f384e4c53421196533c2a2b693efaf8d) > > (`[MC] Disable MCAssembler based constant folding for DwarfDebug`; > > independent of this patch) should have fixed the compile time regression. > >

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-30 Thread via cfe-commits
gulfemsavrun wrote: > @gulfemsavrun Commit > [245491a](https://github.com/llvm/llvm-project/commit/245491a9f384e4c53421196533c2a2b693efaf8d) > (`[MC] Disable MCAssembler based constant folding for DwarfDebug`; > independent of this patch) should have fixed the compile time regression. > Might

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-30 Thread Fangrui Song via cfe-commits
MaskRay wrote: > We started seeing a build time regression in our Clang toolchain builders on > Mac, and I bisected to this commit: > > 1. Build step took 1.7 hours in the last build before (clang -> build) > > [luci-milo.appspot.com/ui/p/fuchsia/builders/prod/clang-mac-x64/b874743907285139

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-30 Thread via cfe-commits
gulfemsavrun wrote: We started seeing a build time regression in our Clang toolchain builders on Mac, and I bisected to this commit: 1) Build step took 1.7 hours in the last build before https://luci-milo.appspot.com/ui/p/fuchsia/builders/prod/clang-mac-x64/b8747439072851399889/overview 2) Bui

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-20 Thread Nikita Popov via cfe-commits
nikic wrote: @MaskRay Thanks! That does fix the regression. https://github.com/llvm/llvm-project/pull/91082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-20 Thread Fangrui Song via cfe-commits
MaskRay wrote: > @MaskRay It looks like the new version still causes large compile-time > regressions for sqlite3 debug builds: > http://llvm-compile-time-tracker.com/compare.php?from=7529fe2e92e79eef22a528a7168e4dd777d6e9bd&to=9500a5d02e23f9b43294e5f662ac099f8989c0e4&stat=instructions:u > It'

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-20 Thread Nikita Popov via cfe-commits
nikic wrote: @MaskRay It looks like the new version still causes large compile-time regressions for sqlite3 debug builds: http://llvm-compile-time-tracker.com/compare.php?from=7529fe2e92e79eef22a528a7168e4dd777d6e9bd&to=9500a5d02e23f9b43294e5f662ac099f8989c0e4&stat=instructions:u It's smaller

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-19 Thread Fangrui Song via cfe-commits
MaskRay wrote: Removing `getUseAssemblerInfoForParsing` would make MCDwarfFrameEmitter::Emit (for .eh_frame FDE) slow (~4% compile time regression for sqlite3.c amalgamation) due to expensive `AttemptToFoldSymbolOffsetDifference`. For now, make `UseAssemblerInfoForParsing` false in MCDwarfFram

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/91082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits