nikic wrote:
Reverted in
https://github.com/llvm/llvm-project/commit/fa750f09be6966de7423ddce1af7d1eaf817182c
due to large compile-time regressions in some cases, see
kparzysz wrote:
Problem solved in 29c2475f215110d9e6b3955d5eb2832b3f719c2f.
https://github.com/llvm/llvm-project/pull/91082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kparzysz wrote:
> But why? I don't know what business MLIR could possibly have touching this,
> for AMDGPU of all things
I don't know why, but my build is failing now.
https://github.com/llvm/llvm-project/pull/91082
___
cfe-commits mailing list
arsenm wrote:
> It's still used:
>
> ```
> /work/kparzysz/git/llvm.org/mlir/lib/Target/LLVM/ROCDL/Target.cpp: In member
> function ‘std::optional >
> mlir::ROCDL::SerializeGPUModuleBase::assembleIsa(llvm::StringRef)’:
> /work/kparzysz/git/llvm.org/mlir/lib/Target/LLVM/ROCDL/Target.cpp:302:15:
kparzysz wrote:
It's still used:
```
/work/kparzysz/git/llvm.org/mlir/lib/Target/LLVM/ROCDL/Target.cpp: In member
function ‘std::optional >
mlir::ROCDL::SerializeGPUModuleBase::assembleIsa(llvm::StringRef)’:
/work/kparzysz/git/llvm.org/mlir/lib/Target/LLVM/ROCDL/Target.cpp:302:15: error:
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/91082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/91082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/91082
>From 7e36c4d9f736b9b2eff29e565d22e01c29744c1e Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Sat, 4 May 2024 13:10:21 -0700
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
https://github.com/smithp35 approved this pull request.
I think it is reasonable to proceed given the RFC and the response.
https://github.com/llvm/llvm-project/pull/91082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaskRay wrote:
> > Thanks for the additional context. My main concern is that we're undoing
> > the consensus of [reviews.llvm.org/D45164](https://reviews.llvm.org/D45164)
> > which if I've understood the comments properly was "There is a reasonable
> > expectation that compiled (not
MaskRay wrote:
> Thanks for the additional context. My main concern is that we're undoing the
> consensus of [reviews.llvm.org/D45164](https://reviews.llvm.org/D45164) which
> if I've understood the comments properly was "There is a reasonable
> expectation that compiled (not assembled) code
smithp35 wrote:
Thanks for the additional context. My main concern is that we're undoing the
consensus of https://reviews.llvm.org/D45164 which if I've understood the
comments properly was "There is a reasonable expectation that compiled (not
assembled) code should be identical, or at least
MaskRay wrote:
This PR will address a Linux kernel need.
https://lore.kernel.org/all/CAFP8O3JkgQsH-4Lmr2W_teuvLjOCPi1htr9r3CO1O0yLyw=a...@mail.gmail.com/
The code already assembles with `clang -S -fno-integrated-as` and `gcc -c`,
and this patch is to make `clang -c` work by removeing an
https://github.com/smithp35 commented:
The code-changes look good, what I'm less sure about is whether this is the
right thing to do unconditionally.
A few months ago I would likely to have said this wouldn't matter that much as
most people don't use `-S` in there build systems so any
llvmbot wrote:
@llvm/pr-subscribers-backend-spir-v
Author: Fangrui Song (MaskRay)
Changes
Commit 6c0665e22174d474050e85ca367424f6e02476be
(https://reviews.llvm.org/D45164) enabled certain constant expression
evaluation for `MCObjectStreamer` at parse time (e.g. `.if` directives,
see
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/91082
Commit 6c0665e22174d474050e85ca367424f6e02476be
(https://reviews.llvm.org/D45164) enabled certain constant expression
evaluation for `MCObjectStreamer` at parse time (e.g. `.if` directives,
see
16 matches
Mail list logo
