[clang] [llvm] [RISCV] Allow extra underscores in parseNormalizedArchString and parseArchString. (PR #91532)

2024-05-09 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/91532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Allow extra underscores in parseNormalizedArchString and parseArchString. (PR #91532)

2024-05-08 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/91532 >From 0f5fcf5035d66fd4c1d1e97525e9266d8460b297 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Wed, 8 May 2024 13:40:31 -0700 Subject: [PATCH] [RISCV] Allow extra underscores in parseNormalizedArchString and

[clang] [llvm] [RISCV] Allow extra underscores in parseNormalizedArchString and parseArchString. (PR #91532)

2024-05-08 Thread Craig Topper via cfe-commits
topperc wrote: > This one seems lazy, avoiding trailing or duplicate underscores is easy. Yeah I don't really expect anyone to use it. It seemed like an unnecessary complication in our parsing code. I was considering getting rid of split call before the loop and make the loop work directly

[clang] [llvm] [RISCV] Allow extra underscores in parseNormalizedArchString and parseArchString. (PR #91532)

2024-05-08 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/91532 >From 6bccebc9415034680426921fcc84d404ff32245d Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Wed, 8 May 2024 13:40:31 -0700 Subject: [PATCH 1/2] [RISCV] Allow extra underscores in parseNormalizedArchString

[clang] [llvm] [RISCV] Allow extra underscores in parseNormalizedArchString and parseArchString. (PR #91532)

2024-05-08 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: This one seems lazy, avoiding trailing or duplicate underscores is easy. https://github.com/llvm/llvm-project/pull/91532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Allow extra underscores in parseNormalizedArchString and parseArchString. (PR #91532)

2024-05-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e3938f4d71493673033f6190454e7e19d5411ea7 6bccebc9415034680426921fcc84d404ff32245d --

[clang] [llvm] [RISCV] Allow extra underscores in parseNormalizedArchString and parseArchString. (PR #91532)

2024-05-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-clang-driver Author: Craig Topper (topperc) Changes Allow double underscores and trailing underscores. gcc and binutils allow extra underscores without error. --- Full diff:

[clang] [llvm] [RISCV] Allow extra underscores in parseNormalizedArchString and parseArchString. (PR #91532)

2024-05-08 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/91532 Allow double underscores and trailing underscores. gcc and binutils allow extra underscores without error. >From 6bccebc9415034680426921fcc84d404ff32245d Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Wed,