[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-07 Thread Donát Nagy via cfe-commits
NagyDonat wrote: The unittest failure seems to be random nonsense, apparently the Python package `psutil` is not available on that windows machine: > llvm-lit.py: C:\a\lld-x86_64-win\build\utils\lit\tests\lit.cfg:111: warning: > Setting a timeout per test not supported. Requires the Python psut

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on `as-worker-93` while building `clang,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2243 Here is the releva

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-06 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/125534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-06 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/125534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-06 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > I assume you intentionally did _not_ rename the ArrayBoundCheckerV2.cpp to > ArrayBoundChecker.cpp to avoid the generating a diff that is much harder to > understand than just the modification and the deletion of the old one. So > consistency will be restored in trivial foll

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-04 Thread Donát Nagy via cfe-commits
NagyDonat wrote: I evaluated a sample of 10 random ArrayBoundV2 results from FFMPEG and I found the following: - [Unjustified assumption of third iteration](https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?run=ffmpeg_n4.3.1_edonnag_llvm-main_1883de3&newcheck=ffmpeg_n4.3.

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-04 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/125534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-04 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/125534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-04 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/125534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-04 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/125534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-04 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. LG! Do you have an intuition where the rest of the false positives are coming from? Are there infeasible paths? Insufficient solvers? Would cross-checking with Z3 reduce the FPs emitted from this check? https://github.com/llvm/llvm-proj

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Donát Nagy (NagyDonat) Changes Before this commit, there were two alpha checkers that used different algorithms/logic for detecting out of bounds memory access: the old `alpha.security.ArrayBou

[clang] [llvm] [analyzer] Consolidate array bound checkers (PR #125534)

2025-02-03 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/125534 Before this commit, there were two alpha checkers that used different algorithms/logic for detecting out of bounds memory access: the old `alpha.security.ArrayBound` and the experimental, more complex `alpha