[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/8] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/AaronBallman approved this pull request. LGTM, thank you for the improvement! https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/8] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/8] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/8] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -2778,7 +2778,9 @@ static bool CheckedIntArithmetic(EvalInfo , const Expr *E, if (Info.checkingForUndefinedBehavior()) Info.Ctx.getDiagnostics().Report(E->getExprLoc(), diag::warn_integer_constant_overflow) - <<

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -175,6 +175,9 @@ Improvements to Clang's diagnostics - The ``-Wshorten-64-to-32`` diagnostic is now grouped under ``-Wimplicit-int-conversion`` instead of ``-Wconversion``. Fixes `#69444 `_. +- Clang now uses thousand

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

Atousa wrote: please @AaronBallman https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/7] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/6] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/6] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -1379,6 +1379,23 @@ TEST(APIntTest, toString) { EXPECT_EQ(std::string(S), "0"); S.clear(); + // with separators + APInt(64, 140).toString(S, 2, false, true, false, true); + EXPECT_EQ(std::string(S), "0b1000'1100"); + S.clear(); + APInt(64, 1024).toString(S, 8,

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -1626,7 +1626,8 @@ class [[nodiscard]] APInt { /// SmallString. If Radix > 10, UpperCase determine the case of letter /// digits. void toString(SmallVectorImpl , unsigned Radix, bool Signed, -bool formatAsCLiteral = false, bool UpperCase = true) const;

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -2257,17 +2266,27 @@ void APInt::toString(SmallVectorImpl , unsigned Radix, bool Signed, unsigned ShiftAmt = (Radix == 16 ? 4 : (Radix == 8 ? 3 : 1)); unsigned MaskAmt = Radix - 1; +int Pos = 0; while (Tmp.getBoolValue()) { unsigned Digit =

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -2257,17 +2266,27 @@ void APInt::toString(SmallVectorImpl , unsigned Radix, bool Signed, unsigned ShiftAmt = (Radix == 16 ? 4 : (Radix == 8 ? 3 : 1)); unsigned MaskAmt = Radix - 1; +int Pos = 0; while (Tmp.getBoolValue()) { unsigned Digit =

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -329,9 +329,10 @@ inline std::string itostr(int64_t X) { } inline std::string toString(const APInt , unsigned Radix, bool Signed, -bool formatAsCLiteral = false) { +bool formatAsCLiteral = false, +

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -2161,7 +2161,8 @@ void APInt::fromString(unsigned numbits, StringRef str, uint8_t radix) { } void APInt::toString(SmallVectorImpl , unsigned Radix, bool Signed, - bool formatAsCLiteral, bool UpperCase) const { + bool

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -2223,9 +2227,14 @@ void APInt::toString(SmallVectorImpl , unsigned Radix, bool Signed, ++Prefix; }; +int Pos = 0; while (N) { + if (insertSeparators && Pos % Grouping == 0 && Pos > 0) { +*--BufPtr = '\''; + }

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/AaronBallman commented: You should also add a release note to `clang/docs/ReleaseNotes.rst` to tell users about the improved diagnostic behavior. Aside from some small nits, this looks really close to ready! https://github.com/llvm/llvm-project/pull/80939

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

Atousa wrote: humble ping @AaronBallman https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

Atousa wrote: @AaronBallman @tbaederr, Do you have any further comments? https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/5] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/5] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

Atousa wrote: Humble ping @cjdb Do you have any further comments? @AaronBallman @tbaederr https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/5] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -2187,6 +2188,12 @@ void APInt::toString(SmallVectorImpl , unsigned Radix, bool Signed, } } + // Number of digits in a group between separators. + unsigned Grouping = (Radix == 8 || Radix == 10) ? 3 : 4; + if (Radix == 8 || Radix == 10) { +Grouping = 3; + }

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/5] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/5] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/5] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/5] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/5] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/4] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/4] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/3] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/2] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -2774,7 +2774,8 @@ static bool CheckedIntArithmetic(EvalInfo , const Expr *E, if (Info.checkingForUndefinedBehavior()) Info.Ctx.getDiagnostics().Report(E->getExprLoc(), diag::warn_integer_constant_overflow) - <<

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -2187,6 +2188,12 @@ void APInt::toString(SmallVectorImpl , unsigned Radix, bool Signed, } } + // Number of digits in a group between separators tbaederr wrote: ```suggestion // Number of digits in a group between separators. ```

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

@@ -2187,6 +2188,12 @@ void APInt::toString(SmallVectorImpl , unsigned Radix, bool Signed, } } + // Number of digits in a group between separators + int Grouping = 4; tbaederr wrote: ```suggestion unsigned Grouping = (Radix == 8 || Radix == 10) ?

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa ready_for_review https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

AaronBallman wrote: Overall, I think this is a *fantastic* idea for diagnostic readability, thank you for the patch! Please be sure to add a release note so users known to expect the changes. The Windows precommit CI failure is unrelated and can be ignored. Once you think you're ready, be

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa edited https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa edited https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-adt Author: Atousa Duprat (Atousa) Changes Add functionality to APInt::toString() that allows it to insert separators between groups of digits, using the C++ litteral separator ' between groups. Fixes issue #58228

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa converted_to_draft https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa ready_for_review https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From b32eb14ee8eaa337fa4efafda30dc02a86667965 Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From c672d736f9cdce9ac9cbbf79df0d5c081d1a0792 Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From 2e5efd9623f10aae54798c4d664c479be93ae77f Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From d04a66e5bc56f4ec09339a202fd6047f570a59ae Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From a73812395e80ef79ce19378cae2aed58ad5b0532 Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From 7dd1c213b650550e0fd47ff1c9d79ee3b510eddb Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From 6ca8091362baf63fcbfeff60816830cc88c5a36f Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From 6dcb144b92ad2cd4198a53aae40f77d3eba3dbca Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff adbf21f12b3069b2554efb39f2e92c6cf6f24940 c3efdb00f58ef91e587d37b08d06982a81ccefc4 --

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

https://github.com/Atousa created https://github.com/llvm/llvm-project/pull/80939 Add functionality to APInt::toString() that allows it to insert separators between groups of digits, using the C++ litteral separator ' between groups. Fixes issue #58228 >From