zeroomega wrote:
> > Hi, I am seeing breakages on some of our audio code on tip of tree Clang
> > and I traced it back to this patch.
> > We uses `-ffast-math` mode for performance reasons but we also uses
> > `-fhonor-infinities`, `-fhonor-nans` and `fno-finite-math-only` to ensure
> > that
AaronBallman wrote:
> > > > > Is this expected and wanted?
> > > >
> > > >
> > > > Good catch! I would not expect that diagnostic; we should silence the
> > > > diagnostic if it's used in a `#ifdef`, `#elifdef`, or `defined` because
> > > > the value isn't necessary. Perhaps we should also
AaronBallman wrote:
> Hi, I am seeing breakages on some of our audio code on tip of tree Clang and
> I traced it back to this patch.
>
> We uses `-ffast-math` mode for performance reasons but we also uses
> `-fhonor-infinities`, `-fhonor-nans` and `fno-finite-math-only` to ensure
> that the
zahiraam wrote:
> Hi, I am seeing breakages on some of our audio code on tip of tree Clang and
> I traced it back to this patch.
>
> We uses `-ffast-math` mode for performance reasons but we also uses
> `-fhonor-infinities`, `-fhonor-nans` and `fno-finite-math-only` to ensure
> that the
https://github.com/andykaylor approved this pull request.
I'm happy with this.
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2835,6 +2835,9 @@ class Preprocessor {
if (Identifier.getIdentifierInfo()->isRestrictExpansion() &&
!SourceMgr.isInMainFile(Identifier.getLocation()))
emitRestrictExpansionWarning(Identifier);
+
+if (Identifier.getIdentifierInfo()->getName() ==