@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Endilll wrote:
@Sh0g0-1758 Please have
Sh0g0-1758 wrote:
gentle ping regarding this :
> @AaronBallman, I don't think it needs templating. After a careful look I
> believe that the current implementation is for `-verify` only. Also the error
> says `err_verify_invalid_no_diags` which implicitly means that we are passing
> no
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/18] Fix : more detailed no expected directive message
---
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
def err_verify_no_directives : Error<
-"no expected
Sh0g0-1758 wrote:
Hey @AaronBallman, I have added a test for the same in
```clang/test/Frontend/verify.c``` and made the necessary changes as well. I
have added a short **PR SUMMARY** to the top-level comment as you instructed.
As for changes in other error messages, I think its best to merge
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Thank you for the fix! Can you please add more description to what is being
fixed and how to the PR summary (as that becomes the commit message when we
land the changes)?
I don't think a release note is necessary because this isn't really a
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
def err_verify_no_directives : Error<
-"no expected
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
-
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
-
https://github.com/Sh0g0-1758 deleted
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
-
https://github.com/tbaederr requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 1/9] Fix : more detailed no expected directive message
---
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 1/8] Fix : more detailed no expected directive message
---
Sh0g0-1758 wrote:
Please see the desired behavior in this screenshot :
With `-verify=` we get `expected-no-diagnostics` and with `-verify=foo` we get
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 51afb101743855e2ae2624ebbe087da77128d92c
75c02dbdc6ce9ba6a7b9df47ff9540943f543f9f --
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
def err_verify_no_directives : Error<
-"no expected
19 matches
Mail list logo
