AaronBallman wrote:
> How do I reopen the PR after fixing the test case?
AIUI, you cannot reopen a merged PR, you have to start a new PR and mention the
old one to link the two together.
https://github.com/llvm/llvm-project/pull/81545
___
huangjd wrote:
How do I reopen the PR after fixing the test case?
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
I think the fix for the breakage is to just pin the new test to a fixed triple
like so `-triple x86_64-linux-gnu`.
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
joker-eph wrote:
Reverted in 7d4a45d98275e669bda40410f064891beb3480ce ; test is failing like
this on Windows:
```
# RUN: at line 3
c:\ws\buildbot\premerge-monolithic-windows\build\bin\clang.exe -cc1
-internal-isystem
C:\ws\buildbot\premerge-monolithic-windows\build\lib\clang\19\include
dyung wrote:
Hi, the test debug-info-ptr-to-ptr.cpp is still failing on a Mac bot. Can you
take a look?
https://lab.llvm.org/buildbot/#/builders/280/builds/4515
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
chenzheng1030 wrote:
PPC buildbot fails at another place with above fix:
https://lab.llvm.org/buildbot/#/builders/230/builds/29066
Commit 2b1d1c51f6e321267cc86e9db7808298c59caf0e to fix the failure.
https://github.com/llvm/llvm-project/pull/81545
dwblaikie wrote:
> There is a broken test in CI:
> https://lab.llvm.org/buildbot/#/builders/272/builds/17864
Fixed in ea1ecb50fa831583241fc531153bd2c072955d29
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
joker-eph wrote:
There is a broken test in CI:
https://lab.llvm.org/buildbot/#/builders/272/builds/17864
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/huangjd closed
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dwblaikie approved this pull request.
Fair enough - let's give it a go.
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
huangjd wrote:
Could I have a follow up on this? @dwblaikie
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5636,6 +5636,84 @@ void
CGDebugInfo::EmitExternalVariable(llvm::GlobalVariable *Var,
Var->addDebugInfo(GVE);
}
+void CGDebugInfo::EmitPseudoVariable(CGBuilderTy ,
+ llvm::Instruction *Value, QualType Ty) {
+ // Only when -g2 or
https://github.com/huangjd updated
https://github.com/llvm/llvm-project/pull/81545
>From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001
From: William Huang
Date: Mon, 12 Feb 2024 02:27:13 -0500
Subject: [PATCH 01/13] Add option to generate additional info for expression
https://github.com/huangjd ready_for_review
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/huangjd converted_to_draft
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5636,6 +5636,84 @@ void
CGDebugInfo::EmitExternalVariable(llvm::GlobalVariable *Var,
Var->addDebugInfo(GVE);
}
+void CGDebugInfo::EmitPseudoVariable(CGBuilderTy ,
+ llvm::Instruction *Value, QualType Ty) {
+ // Only when -g2 or
@@ -5636,6 +5636,84 @@ void
CGDebugInfo::EmitExternalVariable(llvm::GlobalVariable *Var,
Var->addDebugInfo(GVE);
}
+void CGDebugInfo::EmitPseudoVariable(CGBuilderTy ,
+ llvm::Instruction *Value, QualType Ty) {
+ // Only when -g2 or
@@ -5636,6 +5636,84 @@ void
CGDebugInfo::EmitExternalVariable(llvm::GlobalVariable *Var,
Var->addDebugInfo(GVE);
}
+void CGDebugInfo::EmitPseudoVariable(CGBuilderTy ,
+ llvm::Instruction *Value, QualType Ty) {
+ // Only when -g2 or
@@ -1787,7 +1787,26 @@ Value *ScalarExprEmitter::VisitMemberExpr(MemberExpr *E)
{
}
}
- return EmitLoadOfLValue(E);
+ llvm::Value *Result = EmitLoadOfLValue(E);
+
+ // If -fdebug_info_for_profiling is specified, emit a pseudo variable and its
https://github.com/huangjd updated
https://github.com/llvm/llvm-project/pull/81545
>From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001
From: William Huang
Date: Mon, 12 Feb 2024 02:27:13 -0500
Subject: [PATCH 01/12] Add option to generate additional info for expression
@@ -5636,6 +5636,84 @@ void
CGDebugInfo::EmitExternalVariable(llvm::GlobalVariable *Var,
Var->addDebugInfo(GVE);
}
+void CGDebugInfo::EmitPseudoVariable(CGBuilderTy ,
+ llvm::Instruction *Value, QualType Ty) {
+ // Only when -g2 or
@@ -5636,6 +5636,84 @@ void
CGDebugInfo::EmitExternalVariable(llvm::GlobalVariable *Var,
Var->addDebugInfo(GVE);
}
+void CGDebugInfo::EmitPseudoVariable(CGBuilderTy ,
+ llvm::Instruction *Value, QualType Ty) {
+ // Only when -g2 or
@@ -1787,7 +1787,26 @@ Value *ScalarExprEmitter::VisitMemberExpr(MemberExpr *E)
{
}
}
- return EmitLoadOfLValue(E);
+ llvm::Value *Result = EmitLoadOfLValue(E);
+
+ // If -fdebug_info_for_profiling is specified, emit a pseudo variable and its
https://github.com/huangjd updated
https://github.com/llvm/llvm-project/pull/81545
>From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001
From: William Huang
Date: Mon, 12 Feb 2024 02:27:13 -0500
Subject: [PATCH 01/11] Add option to generate additional info for expression
dwblaikie wrote:
> As for impact, I believe @namhyung did some measurement for building the
> Linux kernel, and it does not have a significant impact.
That'd surprise me quite a bit - perhaps a self-host build of clang (ideally in
Google's build config, that being the one you and I care about
huangjd wrote:
I am making another diff (not to be submitted) to get statistics on how
frequently these 2 cases are encountered
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
huangjd wrote:
> > > Reading LLVM IR lit CHECK lines from clang codegen is a bit difficult -
> > > could you include some simple examples (perhaps from the new clang tests
> > > in this patch) showing the DWARF output just as comments in this review
> > > for something more easily glanceable?
dwblaikie wrote:
> > Reading LLVM IR lit CHECK lines from clang codegen is a bit difficult -
> > could you include some simple examples (perhaps from the new clang tests in
> > this patch) showing the DWARF output just as comments in this review for
> > something more easily glanceable?
>
>
https://github.com/huangjd updated
https://github.com/llvm/llvm-project/pull/81545
>From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001
From: William Huang
Date: Mon, 12 Feb 2024 02:27:13 -0500
Subject: [PATCH 1/9] Add option to generate additional info for expression
https://github.com/huangjd updated
https://github.com/llvm/llvm-project/pull/81545
>From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001
From: William Huang
Date: Mon, 12 Feb 2024 02:27:13 -0500
Subject: [PATCH 1/8] Add option to generate additional info for expression
huangjd wrote:
> Reading LLVM IR lit CHECK lines from clang codegen is a bit difficult - could
> you include some simple examples (perhaps from the new clang tests in this
> patch) showing the DWARF output just as comments in this review for something
> more easily glanceable?
Attached is
https://github.com/huangjd updated
https://github.com/llvm/llvm-project/pull/81545
>From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001
From: William Huang
Date: Mon, 12 Feb 2024 02:27:13 -0500
Subject: [PATCH 1/7] Add option to generate additional info for expression
huangjd wrote:
My concern to enable this feature by default is that there are some less known
syntax (probably from other supported languages or extensions) that has a
MemberExpr but actually emitting something unexpected, which could cause a
crash. I am testing this feature on some real-life
dwblaikie wrote:
Reading LLVM IR lit CHECK lines from clang codegen is a bit difficult - could
you include some simple examples (perhaps from the new clang tests in this
patch) showing the DWARF output just as comments in this review for something
more easily glanceable?
As for flags - I
david-xl wrote:
> So the additional debug info for pointer type should be generated when
> -fdebug-info-for-profiling is enabled?
yes, it is extra debug info for profiling (can be used for samplePGO).
https://github.com/llvm/llvm-project/pull/81545
huangjd wrote:
So the additional debug info for pointer type should be generated when
-fdebug-info-for-profiling is enabled?
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/david-xl commented:
Why is a new user facing option needed? I suppose this can be done under
-fdebug-info-for-profiling. An internal option can also be added to disable it.
https://github.com/llvm/llvm-project/pull/81545
___
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the intermediate memory load
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the intermediate memory load
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
@llvm/pr-subscribers-llvm-ir
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the intermediate memory load instruction
https://github.com/huangjd ready_for_review
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/huangjd updated
https://github.com/llvm/llvm-project/pull/81545
>From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001
From: William Huang
Date: Mon, 12 Feb 2024 02:27:13 -0500
Subject: [PATCH 1/5] Add option to generate additional info for expression
https://github.com/huangjd updated
https://github.com/llvm/llvm-project/pull/81545
>From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001
From: William Huang
Date: Mon, 12 Feb 2024 02:27:13 -0500
Subject: [PATCH 1/4] Add option to generate additional info for expression
https://github.com/huangjd updated
https://github.com/llvm/llvm-project/pull/81545
>From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001
From: William Huang
Date: Mon, 12 Feb 2024 02:27:13 -0500
Subject: [PATCH 1/3] Add option to generate additional info for expression
45 matches
Mail list logo
