@@ -1039,6 +1058,177 @@ Expected
ASTNodeImporter::import(ConceptReference *From) {
return ConceptRef;
}
+StringRef ASTNodeImporter::ImportASTStringRef(StringRef FromStr) {
balazske wrote:
Probably an explanation can be added about use of this function. A `
balazske wrote:
If `FromTypeRequirement.isSubstitutionFailure()` can be true at compile error
it can be still possible to call `testImport` or `getTuDecl` with the code.
https://github.com/llvm/llvm-project/pull/138838
___
cfe-commits mailing list
cfe
balazske wrote:
> Newly added VisitSubstNonTypeTemplateParmPackExpr, VisitPseudoObjectExpr,
> VisitCXXParenListInitExpr are also without tests.
> I've faced them on my project, and looks like it is not because of newly
> implemented concepts imports. But I'm not sure. Should I move 'em to separ
https://github.com/ganenkokb-yandex updated
https://github.com/llvm/llvm-project/pull/138838
>From 6a4d62ce1c72639d7fe82565744b3e8808dce4c3 Mon Sep 17 00:00:00 2001
From: Evianaive <153540...@qq.com>
Date: Tue, 25 Mar 2025 01:54:06 +0800
Subject: [PATCH 01/19] Implement missing visit function
-
ganenkokb-yandex wrote:
> Code looks almost acceptable. I could not verify if the tests are sufficient
> (I am not familiar with this new syntax). Can you test this on large projects
> that use these types of expressions?
It is my approach. All fixes aside ASTImporter are came from real cases.
https://github.com/balazske edited
https://github.com/llvm/llvm-project/pull/138838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7359,6 +7549,150 @@ ExpectedStmt ASTNodeImporter::VisitExpr(Expr *E) {
return make_error(ASTImportError::UnsupportedConstruct);
}
+ExpectedStmt ASTNodeImporter::VisitRequiresExpr(RequiresExpr* E) {
+ Error Err = Error::success();
+ auto RequiresKWLoc = importChecked(Er
@@ -1363,6 +1364,26 @@ extern const internal::VariadicDynCastAllOfMatcher
extern const internal::VariadicDynCastAllOfMatcher
conceptDecl;
+/// Matches concept requirement.
+///
+/// Example matches requirement expression
balazske wrote:
It is better to te
@@ -7359,6 +7549,150 @@ ExpectedStmt ASTNodeImporter::VisitExpr(Expr *E) {
return make_error(ASTImportError::UnsupportedConstruct);
}
+ExpectedStmt ASTNodeImporter::VisitRequiresExpr(RequiresExpr* E) {
+ Error Err = Error::success();
+ auto RequiresKWLoc = importChecked(Er
@@ -1363,6 +1364,26 @@ extern const internal::VariadicDynCastAllOfMatcher
extern const internal::VariadicDynCastAllOfMatcher
conceptDecl;
+/// Matches concept requirement.
+///
+/// Example matches requirement expression
+/// \code
+/// template
+/// concept dereferenc
@@ -28,6 +28,7 @@
# Nested build directory
/build*
+/debug*
balazske wrote:
Is this change needed?
https://github.com/llvm/llvm-project/pull/138838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
@@ -1609,6 +1609,12 @@ static bool
IsStructurallyEquivalent(StructuralEquivalenceContext &Context,
static bool IsStructurallyEquivalent(StructuralEquivalenceContext &Context,
CXXMethodDecl *Method1,
CXXM
@@ -7359,6 +7549,150 @@ ExpectedStmt ASTNodeImporter::VisitExpr(Expr *E) {
return make_error(ASTImportError::UnsupportedConstruct);
}
+ExpectedStmt ASTNodeImporter::VisitRequiresExpr(RequiresExpr* E) {
+ Error Err = Error::success();
+ auto RequiresKWLoc = importChecked(Er
https://github.com/balazske commented:
Code looks almost acceptable. I could not verify if the tests are sufficient (I
am not familiar with this new syntax). Can you test this on large projects that
use these types of expressions?
https://github.com/llvm/llvm-project/pull/138838
__
https://github.com/ganenkokb-yandex updated
https://github.com/llvm/llvm-project/pull/138838
>From 6a4d62ce1c72639d7fe82565744b3e8808dce4c3 Mon Sep 17 00:00:00 2001
From: Evianaive <153540...@qq.com>
Date: Tue, 25 Mar 2025 01:54:06 +0800
Subject: [PATCH 01/18] Implement missing visit function
-
https://github.com/ganenkokb-yandex updated
https://github.com/llvm/llvm-project/pull/138838
>From 0a5beb71cb46ad5ef2df753098a6742ffeef3a71 Mon Sep 17 00:00:00 2001
From: Evianaive <153540...@qq.com>
Date: Tue, 25 Mar 2025 01:54:06 +0800
Subject: [PATCH 01/13] Implement missing visit function
-
@@ -1039,6 +1054,177 @@ Expected
ASTNodeImporter::import(ConceptReference *From) {
return ConceptRef;
}
+StringRef ASTNodeImporter::ImportASTStringRef(StringRef FromStr) {
+ char *ToStore = new (Importer.getToContext()) char[FromStr.size()];
+ std::copy(FromStr.begin(), F
https://github.com/ganenkokb-yandex updated
https://github.com/llvm/llvm-project/pull/138838
>From 0a5beb71cb46ad5ef2df753098a6742ffeef3a71 Mon Sep 17 00:00:00 2001
From: Evianaive <153540...@qq.com>
Date: Tue, 25 Mar 2025 01:54:06 +0800
Subject: [PATCH 01/11] Implement missing visit function
-
ganenkokb-yandex wrote:
@balazske tests are ready
https://github.com/llvm/llvm-project/pull/138838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ganenkokb-yandex updated
https://github.com/llvm/llvm-project/pull/138838
>From 0a5beb71cb46ad5ef2df753098a6742ffeef3a71 Mon Sep 17 00:00:00 2001
From: Evianaive <153540...@qq.com>
Date: Tue, 25 Mar 2025 01:54:06 +0800
Subject: [PATCH 01/10] Implement missing visit function
-
https://github.com/ganenkokb-yandex updated
https://github.com/llvm/llvm-project/pull/138838
>From 0a5beb71cb46ad5ef2df753098a6742ffeef3a71 Mon Sep 17 00:00:00 2001
From: Evianaive <153540...@qq.com>
Date: Tue, 25 Mar 2025 01:54:06 +0800
Subject: [PATCH 1/9] Implement missing visit function
---
ganenkokb-yandex wrote:
> I would like better if the code would look like in PR #138845.
I've applied your changes merged with some fixes from my PR. Thanks.
> Additionally tests are needed for all of the new `Decl` and `Expr` nodes.
On my way!
https://github.com/llvm/llvm-project/pull/138838
https://github.com/ganenkokb-yandex updated
https://github.com/llvm/llvm-project/pull/138838
>From 0a5beb71cb46ad5ef2df753098a6742ffeef3a71 Mon Sep 17 00:00:00 2001
From: Evianaive <153540...@qq.com>
Date: Tue, 25 Mar 2025 01:54:06 +0800
Subject: [PATCH 1/8] Implement missing visit function
---
23 matches
Mail list logo
