kazutakahirata wrote:
> @kazutakahirata Please ping here if this persists after
> [3309061](https://github.com/llvm/llvm-project/commit/3309061b2dd8a5cacacf05d956a872617808a974).
> Thanks
@SpencerAbson Your patch indeed fixes the build. Thank you for fixing this
quickly!
https://github.com/
SpencerAbson wrote:
@kazutakahirata Please ping here if this persists after
https://github.com/llvm/llvm-project/commit/3309061b2dd8a5cacacf05d956a872617808a974.
Thanks
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cf
kazutakahirata wrote:
lldb is failing to build with:
```
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4888:13: error:
enumeration values 'MFloat8x8' and 'MFloat8x16' not handled in switch
[-Werror,-Wswitch]
switch (llvm::cast(qual_type)->getKind()) {
^~~
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux`
running on `systemz-1` while building `clang` at step 6 "test-openmp".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/88/builds/3793
Here is the relevant piece of the build log fo
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross`
running on `suse-gary-m68k-cross` while building `clang` at step 5 "ninja check
1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/27/builds/929
Here is the relevant piece of
https://github.com/CarolineConcatto closed
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/paulwalker-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2580,6 +2580,8 @@ void NeonEmitter::runVectorTypes(raw_ostream &OS) {
OS << "typedef __fp16 float16_t;\n";
OS << "#if defined(__aarch64__) || defined(__arm64ec__)\n";
+ OS << "typedef __MFloat8x8_t mfloat8x8_t;\n";
+ OS << "typedef __MFloat8x16_t mfloat8x16_t;\n";
--
@@ -2580,6 +2580,8 @@ void NeonEmitter::runVectorTypes(raw_ostream &OS) {
OS << "typedef __fp16 float16_t;\n";
OS << "#if defined(__aarch64__) || defined(__arm64ec__)\n";
+ OS << "typedef __MFloat8x8_t mfloat8x8_t;\n";
+ OS << "typedef __MFloat8x16_t mfloat8x16_t;\n";
--
@@ -2580,6 +2580,8 @@ void NeonEmitter::runVectorTypes(raw_ostream &OS) {
OS << "typedef __fp16 float16_t;\n";
OS << "#if defined(__aarch64__) || defined(__arm64ec__)\n";
+ OS << "typedef __MFloat8x8_t mfloat8x8_t;\n";
+ OS << "typedef __MFloat8x16_t mfloat8x16_t;\n";
--
@@ -2580,6 +2580,8 @@ void NeonEmitter::runVectorTypes(raw_ostream &OS) {
OS << "typedef __fp16 float16_t;\n";
OS << "#if defined(__aarch64__) || defined(__arm64ec__)\n";
+ OS << "typedef __MFloat8x8_t mfloat8x8_t;\n";
+ OS << "typedef __MFloat8x16_t mfloat8x16_t;\n";
--
@@ -2580,6 +2580,8 @@ void NeonEmitter::runVectorTypes(raw_ostream &OS) {
OS << "typedef __fp16 float16_t;\n";
OS << "#if defined(__aarch64__) || defined(__arm64ec__)\n";
+ OS << "typedef __MFloat8x8_t mfloat8x8_t;\n";
+ OS << "typedef __MFloat8x16_t mfloat8x16_t;\n";
--
https://github.com/paulwalker-arm edited
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/paulwalker-arm commented:
I can be persuaded if there are good reasons for the `TypeSpec` side to wait,
but the the current placement of the typedefs looks wrong.
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mail
https://github.com/paulwalker-arm edited
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -97,6 +97,17 @@
SVE_TYPE(Name, Id, SingletonId)
#endif
+#ifndef AARCH64_VECTOR_TYPE
paulwalker-arm wrote:
I agree. Carol and I discussed this previously and I asked her to ignore the
obvious structural/naming issues and focus on adding the new types in
@@ -97,6 +97,17 @@
SVE_TYPE(Name, Id, SingletonId)
#endif
+#ifndef AARCH64_VECTOR_TYPE
momchil-velikov wrote:
This naming seems odd to me. So, far we've got a sort of taxonomy, or "isA"
relationship
that looks like:
SVE_VECTOR_TYPE_BFLOAT -> SVE_VECTO
@@ -181,11 +192,16 @@ SVE_PREDICATE_TYPE_ALL("__clang_svboolx4_t",
"svboolx4_t", SveBoolx4, SveBoolx4T
SVE_OPAQUE_TYPE("__SVCount_t", "__SVCount_t", SveCount, SveCountTy)
+AARCH64_VECTOR_TYPE_MFLOAT("__MFloat8x8_t", "__MFloat8x8_t", MFloat8x8,
MFloat8x8Ty, 8, 8, 1)
+AARCH64
@@ -6438,6 +6438,8 @@ static llvm::FixedVectorType *GetNeonType(CodeGenFunction
*CGF,
case NeonTypeFlags::Int8:
case NeonTypeFlags::Poly8:
return llvm::FixedVectorType::get(CGF->Int8Ty, V1Ty ? 1 : (8 << IsQuad));
+ case NeonTypeFlags::MFloat8:
Carolin
@@ -323,6 +323,8 @@ static QualType getNeonEltType(NeonTypeFlags Flags,
ASTContext &Context,
switch (Flags.getEltType()) {
case NeonTypeFlags::Int8:
return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
+ case NeonTypeFlags::MFloat8:
-
@@ -101,7 +101,8 @@ enum EltType {
Float16,
Float32,
Float64,
- BFloat16
+ BFloat16,
+ MFloat8,
CarolineConcatto wrote:
Done
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-
@@ -181,11 +192,16 @@ SVE_PREDICATE_TYPE_ALL("__clang_svboolx4_t",
"svboolx4_t", SveBoolx4, SveBoolx4T
SVE_OPAQUE_TYPE("__SVCount_t", "__SVCount_t", SveCount, SveCountTy)
+AARCH64_VECTOR_TYPE_MFLOAT("__MFloat8x8_t", "__MFloat8x8_t", MFloat8x8,
MFloat8x8Ty, 8, 8, 1)
+AARCH64
@@ -2239,6 +2239,12 @@ TypeInfo ASTContext::getTypeInfoImpl(const Type *T)
const {
Width = 0;
\
Align = 16;
\
break;
+#define AARCH64_VE
@@ -506,6 +506,8 @@ llvm::Type *CodeGenTypes::ConvertType(QualType T) {
#define SVE_PREDICATE_TYPE(Name, MangledName, Id, SingletonId)
\
case BuiltinType::Id:
#define SVE_OPAQUE_TYPE(Name, MangledName, Id, SingletonId)
+#define AARCH64_VECTOR_TYPE(Name, Mangl
@@ -150,6 +151,7 @@ class Type {
UInt,
Poly,
BFloat16,
+MFloat8,
CarolineConcatto wrote:
Done
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
@@ -6438,6 +6438,8 @@ static llvm::FixedVectorType *GetNeonType(CodeGenFunction
*CGF,
case NeonTypeFlags::Int8:
case NeonTypeFlags::Poly8:
return llvm::FixedVectorType::get(CGF->Int8Ty, V1Ty ? 1 : (8 << IsQuad));
+ case NeonTypeFlags::MFloat8:
Spencer
@@ -2239,6 +2239,12 @@ TypeInfo ASTContext::getTypeInfoImpl(const Type *T)
const {
Width = 0;
\
Align = 16;
\
break;
+#define AARCH64_VE
@@ -220,6 +221,7 @@ namespace clang {
switch (getEltType()) {
case Int8:
case Poly8:
+ case MFloat8:
SpencerAbson wrote:
This could be removed (if we are not adding support for intrinsics in this
patch).
https://github.com/llvm/llvm-pr
@@ -198,7 +198,8 @@ namespace clang {
Float16,
Float32,
Float64,
- BFloat16
+ BFloat16,
+ MFloat8
SpencerAbson wrote:
(As discussed) I'm not sure that the work here relating to intrinsics is
necessary for this patch, and it ca
@@ -181,11 +192,16 @@ SVE_PREDICATE_TYPE_ALL("__clang_svboolx4_t",
"svboolx4_t", SveBoolx4, SveBoolx4T
SVE_OPAQUE_TYPE("__SVCount_t", "__SVCount_t", SveCount, SveCountTy)
+AARCH64_VECTOR_TYPE_MFLOAT("__MFloat8x8_t", "__MFloat8x8_t", MFloat8x8,
MFloat8x8Ty, 8, 8, 1)
+AARCH64
@@ -101,7 +101,8 @@ enum EltType {
Float16,
Float32,
Float64,
- BFloat16
+ BFloat16,
+ MFloat8,
SpencerAbson wrote:
This could be removed (if we are not adding support for intrinsics in this
patch).
https://github.com/llvm/llvm-project/pull/99865
__
@@ -778,7 +780,7 @@ Type Type::fromTypedefName(StringRef Name) {
T.Kind = Poly;
} else if (Name.consume_front("bfloat")) {
T.Kind = BFloat16;
- } else {
SpencerAbson wrote:
unrelated change here - also the source of the clang-format peril!
https://
@@ -323,6 +323,8 @@ static QualType getNeonEltType(NeonTypeFlags Flags,
ASTContext &Context,
switch (Flags.getEltType()) {
case NeonTypeFlags::Int8:
return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
+ case NeonTypeFlags::MFloat8:
-
https://github.com/SpencerAbson commented:
I don't have much experience around this, so I might have missed some things -
but hopefully this is helpful!
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-commits@lists.llv
@@ -150,6 +151,7 @@ class Type {
UInt,
Poly,
BFloat16,
+MFloat8,
SpencerAbson wrote:
This could be removed (if we are not adding support for intrinsics in this
patch).
https://github.com/llvm/llvm-project/pull/99865
__
@@ -506,6 +506,8 @@ llvm::Type *CodeGenTypes::ConvertType(QualType T) {
#define SVE_PREDICATE_TYPE(Name, MangledName, Id, SingletonId)
\
case BuiltinType::Id:
#define SVE_OPAQUE_TYPE(Name, MangledName, Id, SingletonId)
+#define AARCH64_VECTOR_TYPE(Name, Mangl
https://github.com/SpencerAbson edited
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3437,8 +3447,8 @@ StringRef BuiltinType::getName(const PrintingPolicy
&Policy) const {
case Id: \
return #ExtType;
#include "clang/Basic/OpenCLExtensionTypes.def"
-#define SVE_TYPE(Name, Id, SingletonId) \
- case Id: \
+#define SVE_TYPE(Name, Id, SingletonId)
https://github.com/CarolineConcatto updated
https://github.com/llvm/llvm-project/pull/99865
>From bfcf7c00a0f7e2c619666d72bad4a48928c4b786 Mon Sep 17 00:00:00 2001
From: Caroline Concatto
Date: Mon, 24 Jun 2024 09:59:24 +
Subject: [PATCH 1/4] [CLANG][AArch64] Add the modal 8 bit floating-p
https://github.com/CarolineConcatto updated
https://github.com/llvm/llvm-project/pull/99865
>From bfcf7c00a0f7e2c619666d72bad4a48928c4b786 Mon Sep 17 00:00:00 2001
From: Caroline Concatto
Date: Mon, 24 Jun 2024 09:59:24 +
Subject: [PATCH 1/3] [CLANG][AArch64] Add the modal 8 bit floating-p
https://github.com/CarolineConcatto edited
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/CarolineConcatto edited
https://github.com/llvm/llvm-project/pull/99865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
42 matches
Mail list logo
