Re: [clang] 975467e - [Diagnostics] Handle string concat pattern and avoid false positives

2020-08-09 Thread Dávid Bolvanský via cfe-commits
We warn if it is just one occurance and next literal is not split too. I changed test to test other scenario. I could add that test back, but I think we have enough tests to cover code. We should not warn for code pattern: { “a” “b”, “c” “d” } > Dňa 9. 8. 2020 o 17:49 užívateľ Arthur

Re: [clang] 975467e - [Diagnostics] Handle string concat pattern and avoid false positives

2020-08-09 Thread Arthur O'Dwyer via cfe-commits
Hi Dávid, Does this part of the patch imply that we *don't *want to warn on "foo" TWO ? and if so, why not? Anyway, I think at least "foo" TWO should be kept in the test suite, as a test-for-absence-of-warning. TWO "bar", - "foo"

[clang] 975467e - [Diagnostics] Handle string concat pattern and avoid false positives

2020-08-09 Thread Dávid Bolvanský via cfe-commits
Author: Dávid Bolvanský Date: 2020-08-09T16:02:41+02:00 New Revision: 975467e4aa7ce1b8fcf4af0e25cdf053cfa8669e URL: https://github.com/llvm/llvm-project/commit/975467e4aa7ce1b8fcf4af0e25cdf053cfa8669e DIFF: