[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-24 Thread Richard Smith via cfe-commits
https://github.com/zygoloid created https://github.com/llvm/llvm-project/pull/96573 Explicitly describe how the Clang builtin works, given that it's not exactly the same as GCC's builtin of the same name -- but is drop-in compatible. Fixes #95635. >From 3394d999888087535db9ede87668829eddc33ac

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Richard Smith (zygoloid) Changes Explicitly describe how the Clang builtin works, given that it's not exactly the same as GCC's builtin of the same name -- but is drop-in compatible. Fixes #95635. --- Full diff: https://github.com/llvm/l

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Allan Jude via cfe-commits
@@ -5368,16 +5368,85 @@ The ``#pragma comment(lib, ...)`` directive is supported on all ELF targets. The second parameter is the library name (without the traditional Unix prefix of ``lib``). This allows you to provide an implicit link of dependent libraries. -Evaluating Ob

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Allan Jude via cfe-commits
https://github.com/allanjude edited https://github.com/llvm/llvm-project/pull/96573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Richard Smith via cfe-commits
@@ -5368,16 +5368,85 @@ The ``#pragma comment(lib, ...)`` directive is supported on all ELF targets. The second parameter is the library name (without the traditional Unix prefix of ``lib``). This allows you to provide an implicit link of dependent libraries. -Evaluating Ob

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Richard Smith via cfe-commits
https://github.com/zygoloid updated https://github.com/llvm/llvm-project/pull/96573 >From 3394d999888087535db9ede87668829eddc33ac7 Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Mon, 24 Jun 2024 15:52:18 -0700 Subject: [PATCH 1/2] Add documentation for `__builtin_object_size`. Explicitly d

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Thank you for the additional docs, they LGTM! https://github.com/llvm/llvm-project/pull/96573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Bill Wendling via cfe-commits
bwendling wrote: This LGTM as well. I have a question about the "sub-object" part. Do we attempt to discover the sub-object past any casting? A motivating example: ```c char mux[10][10][10]; printf("%ld\n", __builtin_dynamic_object_size(&((char *)&mux[1][1])[var], 1)); ``` GCC prints `89` (wh

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Richard Smith via cfe-commits
zygoloid wrote: > I have a question about the "sub-object" part. Do we attempt to discover the > sub-object past any casting? Good question. I'm going to merge this PR, so I've filed #96737 for this ongoing discussion. https://github.com/llvm/llvm-project/pull/96573 __

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Richard Smith via cfe-commits
https://github.com/zygoloid closed https://github.com/llvm/llvm-project/pull/96573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits