[clang] Added removal of file extension when guessing the toolchain (PR #69887)

2023-11-06 Thread via cfe-commits
Overhatted wrote: That's fair, I will change buck to either write cl.exe or to add that driver mode flag. Thanks. https://github.com/llvm/llvm-project/pull/69887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] Added removal of file extension when guessing the toolchain (PR #69887)

2023-11-06 Thread via cfe-commits
https://github.com/Overhatted closed https://github.com/llvm/llvm-project/pull/69887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Added removal of file extension when guessing the toolchain (PR #69887)

2023-11-05 Thread Fangrui Song via cfe-commits
MaskRay wrote: In quite a few places we only detect `.exe` as the extension name. I am not sure we should commit to arbitrary extension name now. The build systems can consider `--driver-mode=cl` https://github.com/llvm/llvm-project/pull/69887 ___ cf

[clang] Added removal of file extension when guessing the toolchain (PR #69887)

2023-11-05 Thread via cfe-commits
Overhatted wrote: @MaskRay Pinging. Please let me know if I should tag someone else. https://github.com/llvm/llvm-project/pull/69887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Added removal of file extension when guessing the toolchain (PR #69887)

2023-10-24 Thread via cfe-commits
Overhatted wrote: @MaskRay I can't add reviewers to the PR, not sure if I should tag the code owner or if I should just wait. Sorry to bother you in case I was meant to wait. https://github.com/llvm/llvm-project/pull/69887 ___ cfe-commits mailing list

[clang] Added removal of file extension when guessing the toolchain (PR #69887)

2023-10-22 Thread via cfe-commits
https://github.com/Overhatted created https://github.com/llvm/llvm-project/pull/69887 I'm using Buck2 to create the compile_commands.json and since it uses a cl.bat wrapper around cl.exe, that's what shows up in the compile_commands.json. Of course Buck2 could be changed to create a compile_co