[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= ,Nhat Nguyen Message-ID: In-Reply-To: erichkeane wrote: > > Looks like all the tests disappeared? Only thing I see is the code change. > > Also, no release note is currently present. > > Hi I

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= ,Nhat Nguyen Message-ID: In-Reply-To: changkhothuychung wrote: > Looks like all the tests disappeared? Only thing I see is the code change. > Also, no release note is currently present. Hi I

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= ,Nhat Nguyen Message-ID: In-Reply-To: erichkeane wrote: Looks like all the tests disappeared? Only thing I see is the code change. Also, no release note is currently present.

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= ,Nhat Nguyen Message-ID: In-Reply-To: https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: @@ -17146,7 +17146,13 @@ static bool ConvertAPValueToString(const APValue , QualType T, break; } } -

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?=E2=80=9CNhat?= , =?utf-8?q?=E2=80=9CNhat?= , =?utf-8?q?=E2=80=9CNhat?= , =?utf-8?q?=E2=80=9CNhat?= , =?utf-8?q?=E2=80=9CNhat?= Message-ID: In-Reply-To: https://github.com/ShamrockLee requested changes to this pull request. https://github.com/llvm/llvm-project/pull/75902

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/ShamrockLee edited https://github.com/llvm/llvm-project/pull/75902 ___ cfe-commits mailing list

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/ShamrockLee edited https://github.com/llvm/llvm-project/pull/75902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/ShamrockLee edited https://github.com/llvm/llvm-project/pull/75902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: @@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth =

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: @@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth =

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: @@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth =

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001 From:

[clang] Avoid printing overly large integer. (PR #75902)

=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9CNhat?= Date: Mon,

[clang] Avoid printing overly large integer. (PR #75902)

@@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth = Context.getIntWidth(T); assert(8 <= TyWidth && TyWidth <= 32 && "Unexpected integer width"); + if

[clang] Avoid printing overly large integer. (PR #75902)

@@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth = Context.getIntWidth(T); assert(8 <= TyWidth && TyWidth <= 32 && "Unexpected integer width"); + if

[clang] Avoid printing overly large integer. (PR #75902)

changkhothuychung wrote: Thanks everyone for the comments! I will address as soon as I can. https://github.com/llvm/llvm-project/pull/75902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Avoid printing overly large integer. (PR #75902)

@@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth = Context.getIntWidth(T); assert(8 <= TyWidth && TyWidth <= 32 && "Unexpected integer width"); + if

[clang] Avoid printing overly large integer. (PR #75902)

@@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth = Context.getIntWidth(T); assert(8 <= TyWidth && TyWidth <= 32 && "Unexpected integer width"); + if

[clang] Avoid printing overly large integer. (PR #75902)

ShamrockLee wrote: Some commits doesn't relate to the GitHub account correctly. This may result from incorrect `user.name` and `user.email` settings in your local Git repository.

[clang] Avoid printing overly large integer. (PR #75902)

https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 0eb58740f33f2eef29c28e43e78118f9f0eea4b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9CNhat?= <“nhat7...@gmail.com”> Date: Tue, 19 Dec 2023 00:03:28 -0800 Subject: [PATCH 1/4] return false if

[clang] Avoid printing overly large integer. (PR #75902)

https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 0eb58740f33f2eef29c28e43e78118f9f0eea4b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9CNhat?= <“nhat7...@gmail.com”> Date: Tue, 19 Dec 2023 00:03:28 -0800 Subject: [PATCH 1/3] return false if

[clang] Avoid printing overly large integer. (PR #75902)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 497b2ebb9edcfd5315586b796f47589e9820b4b9 5e6326fb1cf4f1591fe927c94b1d16d1a7be0e66 --

[clang] Avoid printing overly large integer. (PR #75902)

changkhothuychung wrote: Thanks, I will look into adding tests! Regarding the floating point option, are we converting the value to float type and just print it to the output stream? @cor3ntin https://github.com/llvm/llvm-project/pull/75902 ___

[clang] Avoid printing overly large integer. (PR #75902)

https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 0eb58740f33f2eef29c28e43e78118f9f0eea4b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9CNhat?= <“nhat7...@gmail.com”> Date: Tue, 19 Dec 2023 00:03:28 -0800 Subject: [PATCH 1/2] return false if

[clang] Avoid printing overly large integer. (PR #75902)

https://github.com/ShamrockLee edited https://github.com/llvm/llvm-project/pull/75902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid printing overly large integer. (PR #75902)

shafik wrote: > I agree with @tbaederr, fixing the underlying issue - either by optimizing > divide (good luck!) or printing in hexadecimal, seems like a better solution. > At the minimum, we should have a fixme comment to explain the restriction > > @tbaederr @erichkeane @shafik opinion? I

[clang] Avoid printing overly large integer. (PR #75902)

cor3ntin wrote: I agree with @tbaederr, fixing the underlying issue - either by optimizing divide (good luck!) or printing in hexadecimal, seems like a better solution. At the minimum, we should have a fixme comment to explain the restriction @tbaederr @erichkeane @shafik opinion?

[clang] Avoid printing overly large integer. (PR #75902)

@@ -17132,6 +17132,9 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth = Context.getIntWidth(T); assert(8 <= TyWidth && TyWidth <= 32 && "Unexpected integer width"); + if

[clang] Avoid printing overly large integer. (PR #75902)

jroelofs wrote: This also needs a test case. https://github.com/llvm/llvm-project/pull/75902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid printing overly large integer. (PR #75902)

@@ -17132,6 +17132,9 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth = Context.getIntWidth(T); assert(8 <= TyWidth && TyWidth <= 32 && "Unexpected integer width"); + if

[clang] Avoid printing overly large integer. (PR #75902)

https://github.com/HoBoIs edited https://github.com/llvm/llvm-project/pull/75902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid printing overly large integer. (PR #75902)

@@ -17132,6 +17132,9 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth = Context.getIntWidth(T); assert(8 <= TyWidth && TyWidth <= 32 && "Unexpected integer width"); + if

[clang] Avoid printing overly large integer. (PR #75902)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Nhat Nguyen (changkhothuychung) Changes Created a PR to fix issue #71675 --- Full diff: https://github.com/llvm/llvm-project/pull/75902.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaDeclCXX.cpp (+3) ``diff diff

[clang] Avoid printing overly large integer. (PR #75902)

https://github.com/changkhothuychung created https://github.com/llvm/llvm-project/pull/75902 Created a PR to fix issue #71675 >From 0eb58740f33f2eef29c28e43e78118f9f0eea4b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9CNhat?= <“nhat7...@gmail.com”> Date: Tue, 19 Dec 2023 00:03:28 -0800