Endilll wrote:
If Aaron weren't able to fix this in several commits, I'm not sure it's a `good
first issue`.
https://github.com/llvm/llvm-project/pull/67673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
erichkeane wrote:
I missed the compiler-rt bit there, thats a real shame, this is a really
valueable patch that I'd hope someone would take up. While "GCC Doesnt Error"
isn't particularly compelling and we SHOULD be better than that, I'd also
prefer not throwing the baby out with the bath wat
AaronBallman wrote:
> > > (Was out of town...)
> > > As mentioned at [#67360
> > > (comment)](https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374)
> > > , I think a default error is probably not appropriate. A priority value
> > > <= 100 may compete with a runtime `__attrib
erichkeane wrote:
> > (Was out of town...)
> > As mentioned at [#67360
> > (comment)](https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374)
> > , I think a default error is probably not appropriate. A priority value <=
> > 100 may compete with a runtime `__attribute__((const
AaronBallman wrote:
> (Was out of town...)
>
> As mentioned at [#67360
> (comment)](https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374)
> , I think a default error is probably not appropriate. A priority value <=
> 100 may compete with a runtime `__attribute__((constructo
MaskRay wrote:
(Was out of town...)
As mentioned at
https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374 , I
think a default error is probably not appropriate. A priority value <= 100 may
compete with a runtime `__attribute__((constructor(X)))` but more often it will
work.
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/67673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/67673
>From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Thu, 28 Sep 2023 09:20:12 -0400
Subject: [PATCH 1/7] Diagnose problematic uses of constructor/destructor
att
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/67673
>From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Thu, 28 Sep 2023 09:20:12 -0400
Subject: [PATCH 1/5] Diagnose problematic uses of constructor/destructor
att
@@ -2352,26 +2352,126 @@ static void handleUnusedAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL));
}
-static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
- uint32_t priority = ConstructorAttr::De
@@ -2352,26 +2352,126 @@ static void handleUnusedAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL));
}
-static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
- uint32_t priority = ConstructorAttr::De
https://github.com/nickdesaulniers edited
https://github.com/llvm/llvm-project/pull/67673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2352,26 +2352,126 @@ static void handleUnusedAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL));
}
-static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
- uint32_t priority = ConstructorAttr::De
@@ -2352,26 +2352,126 @@ static void handleUnusedAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL));
}
-static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
- uint32_t priority = ConstructorAttr::De
jhuber6 wrote:
I already changed the `init_fini_array_test` while I fixed an unrelated
problem, so it should be fine now.
https://github.com/llvm/llvm-project/pull/67673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
AaronBallman wrote:
Ping, especially @MaskRay
https://github.com/llvm/llvm-project/pull/67673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/67673
>From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Thu, 28 Sep 2023 09:20:12 -0400
Subject: [PATCH 1/4] Diagnose problematic uses of constructor/destructor
att
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/67673
>From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Thu, 28 Sep 2023 09:20:12 -0400
Subject: [PATCH 1/3] Diagnose problematic uses of constructor/destructor
att
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/67673
>From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Thu, 28 Sep 2023 09:20:12 -0400
Subject: [PATCH 1/2] Diagnose problematic uses of constructor/destructor
att
AaronBallman wrote:
> I _think_ I made the correct changes in compiler-rt's CMake so that all of
> the compiler-rt projects can use reserved priorities, but I'd appreciate
> confirmation from @MaskRay on those changes.
Hmm, nope, it seems the test cases still fail (but the source files work).
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c51857b4e53031753d6b998ce0ef5f59c073aeb3
02565df450927fac88062f526a167c9beb518c2f --
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Functions with these attributes will be automatically called before main() or
after main() exits gracefully. In glibc environments, the constructor function
is passed the same arguments as main(), so that signature is allowed. In all
othe
AaronBallman wrote:
This is another pass at https://github.com/llvm/llvm-project/pull/67360
Note: llvm-libc will still have a test failure until I figure out the correct
way to repair init_fini_array_test.cpp. I *think* I made the correct changes in
compiler-rt's CMake so that all of the compi
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/67673
Functions with these attributes will be automatically called before main() or
after main() exits gracefully. In glibc environments, the constructor function
is passed the same arguments as main(), so that s
24 matches
Mail list logo
