https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/70341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/70341
>From f068b471efa81d60d1d6e2c98da56be58958a015 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Thu, 26 Oct 2023 10:53:06 -0400
Subject: [PATCH 1/2] Diagnose use of VLAs in a coroutine
Fixes https://githu
https://github.com/erichkeane approved this pull request.
The comment suggestion makes sense to me, else just needs a release note.
https://github.com/llvm/llvm-project/pull/70341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/70341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
> LGTM but it is missing a release note :)
it may be fine to not mention it clearly since VLAs in coroutines never got
compiled.. user might meet backend crashes..
https://github.com/llvm/llvm-project/pull/70341
___
cfe-commits mail
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/70341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1198,6 +1198,11 @@ void Sema::CheckCompletedCoroutineBody(FunctionDecl *FD,
Stmt *&Body) {
if (FD->hasAttr())
Diag(FD->getLocation(), diag::warn_always_inline_coroutine);
+ // We don't allow use of VLAs within a coroutine, so diagnose if we've seen
https://github.com/ChuanqiXu9 approved this pull request.
Thanks! LGTM with a nit.
https://github.com/llvm/llvm-project/pull/70341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/70341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
LGTM but it is missing a release note :)
https://github.com/llvm/llvm-project/pull/70341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-coroutines
Author: Aaron Ballman (AaronBallman)
Changes
Fixes https://github.com/llvm/llvm-project/issues/65858
---
Full diff: https://github.com/llvm/llvm-project/pull/70341.diff
5 Files Affected:
- (modified) clang/include/clang/Basic/DiagnosticSem
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/70341
Fixes https://github.com/llvm/llvm-project/issues/65858
>From f068b471efa81d60d1d6e2c98da56be58958a015 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Thu, 26 Oct 2023 10:53:06 -0400
Subject: [PATCH] Dia
12 matches
Mail list logo