arsenm wrote:
Superseded by #108853
https://github.com/llvm/llvm-project/pull/107598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm closed
https://github.com/llvm/llvm-project/pull/107598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
This is a duplicate solution of
https://github.com/llvm/llvm-project/pull/108853. Closing it if no objection
from reviewers.
https://github.com/llvm/llvm-project/pull/107598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107598
>From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 6 Sep 2024 08:01:25 -0700
Subject: [PATCH 1/7] Don't emit int TBAA metadata on more complex FP math
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple
x86_64-unknown-unknown -o - %s | FileCheck %s -check-prefixes=CHECK
+// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple x86_64-pc-win64 -o -
%s | FileCheck %s -check-prefixes=CHECK
+// RUN: %clan
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107598
>From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 6 Sep 2024 08:01:25 -0700
Subject: [PATCH 1/6] Don't emit int TBAA metadata on more complex FP math
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple
x86_64-unknown-unknown -o - %s | FileCheck %s -check-prefixes=CHECK
+// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple x86_64-pc-win64 -o -
%s | FileCheck %s -check-prefixes=CHECK
+// RUN: %clan
@@ -686,6 +686,20 @@ static Value *EmitSignBit(CodeGenFunction &CGF, Value *V) {
return CGF.Builder.CreateICmpSLT(V, Zero);
}
+static bool hasPointerArgsOrPointerReturnType(const Value *V) {
+ if (const CallBase *CB = dyn_cast(V)) {
+for (const Value *A : CB->args()) {
@@ -699,9 +713,12 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const
FunctionDecl *FD,
bool ConstWithoutErrnoAndExceptions =
Context.BuiltinInfo.isConstWithoutErrnoAndExceptions(BuiltinID);
// Restrict to target with errno, for example, MacOS doesn't
@@ -686,6 +686,20 @@ static Value *EmitSignBit(CodeGenFunction &CGF, Value *V) {
return CGF.Builder.CreateICmpSLT(V, Zero);
}
+static bool hasPointerArgsOrPointerReturnType(const Value *V) {
+ if (const CallBase *CB = dyn_cast(V)) {
+for (const Value *A : CB->args()) {
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107598
>From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 6 Sep 2024 08:01:25 -0700
Subject: [PATCH 1/5] Don't emit int TBAA metadata on more complex FP math
@@ -699,9 +699,20 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const
FunctionDecl *FD,
bool ConstWithoutErrnoAndExceptions =
Context.BuiltinInfo.isConstWithoutErrnoAndExceptions(BuiltinID);
// Restrict to target with errno, for example, MacOS doesn't
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107598
>From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 6 Sep 2024 08:01:25 -0700
Subject: [PATCH 1/4] Don't emit int TBAA metadata on more complex FP math
@@ -699,9 +699,20 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const
FunctionDecl *FD,
bool ConstWithoutErrnoAndExceptions =
Context.BuiltinInfo.isConstWithoutErrnoAndExceptions(BuiltinID);
// Restrict to target with errno, for example, MacOS doesn't
@@ -699,9 +699,20 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const
FunctionDecl *FD,
bool ConstWithoutErrnoAndExceptions =
Context.BuiltinInfo.isConstWithoutErrnoAndExceptions(BuiltinID);
// Restrict to target with errno, for example, MacOS doesn't
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Zahira Ammarguellat (zahiraam)
Changes
In https://github.com/llvm/llvm-project/pull/100302, `int` TBAA information
was added to math function calls to indicate the type of non-argument memory a
function might modify. The purpose
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/107598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107598
>From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 6 Sep 2024 08:01:25 -0700
Subject: [PATCH 1/3] Don't emit int TBAA metadata on more complex FP math
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107598
>From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 6 Sep 2024 08:01:25 -0700
Subject: [PATCH 1/2] Don't emit int TBAA metadata on more complex FP math
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff eec1fac9b51d06c8afafe9952a20ba7cd4c3ce1c
0763f8d25194e18a040d4cd4cde7c88b6fccbb44 --e
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/107598
In https://github.com/llvm/llvm-project/pull/100302, `int` TBAA information
was added to math function calls to indicate the type of non-argument memory a
function might modify. The purpose of this change was
21 matches
Mail list logo
