[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Fangrui Song via cfe-commits
@@ -44,3 +47,4 @@ // CHECK-NOT: -complex-range=fortran // WARN1: warning: overriding '-fcx-limited-range' option with '-fcx-fortran-rules' [-Woverriding-option] // WARN2: warning: overriding '-fcx-fortran-rules' option with '-fcx-limited-range' [-Woverriding-option] +// range

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. . https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Fix erroneous warning. I'd suggest a more descriptive title, e.g. `[Driver] Fix erroneous warning for -fcx-limited-range and -fcx-fortran-rules` Please also mention #70244 in the description. I am not familiar with the two options, I'll trust your judgement as the author of #

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > I don't think we need a Release note for it since this was a faulty behavior > to start with. It's not related to any of the options. Ah, good to know, thanks! > Would be nice to cherry-pick. Not sure how to do that though. https://llvm.org/docs/GitHub.html#backporting-f

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Thank you for the fix! Can you add some more description to the patch summary > as to what's erroneous (the summary ends up becoming the commit message, so a > terse summary can be harmful for later code archeology). > > Do we need a release note for this? Are you planning to

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Aaron Ballman via cfe-commits
@@ -44,3 +47,4 @@ // CHECK-NOT: -complex-range=fortran // WARN1: warning: overriding '-fcx-limited-range' option with '-fcx-fortran-rules' [-Woverriding-option] // WARN2: warning: overriding '-fcx-fortran-rules' option with '-fcx-limited-range' [-Woverriding-option] +// range

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for the fix! Can you add some more description to the patch summary as to what's erroneous (the summary ends up becoming the commit message, so a terse summary can be harmful for later code archeology). Do we need a release note for this? Ar

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zahira Ammarguellat (zahiraam) Changes This patch is to remove erroneous warning. See https://godbolt.org/z/bYP8P8nqY --- Full diff: https://github.com/llvm/llvm-project/pull/79821.diff 2 Files Affected: - (modified) clang/lib/Driver/To

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/79821 This patch is to remove warning. See https://godbolt.org/z/bYP8P8nqY >From c22d670259f1d9fc22b6e01bf19d1f2316b1d617 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 29 Jan 2024 04:56:13 -0800 Subject: [PA