https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/83487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/83487
>From 1c443bec9f11c14f8971d5dcb03d12e50c080afc Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Thu, 29 Feb 2024 13:29:02 -0800
Subject: [PATCH 1/3] Fix implementation of [temp.param]p14's first sentence.
The fi
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/83487
>From 1c443bec9f11c14f8971d5dcb03d12e50c080afc Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Thu, 29 Feb 2024 13:29:02 -0800
Subject: [PATCH 1/3] Fix implementation of [temp.param]p14's first sentence.
The fi
https://github.com/AaronBallman approved this pull request.
Thanks for the details, then LGTM with a release note added when landing.
https://github.com/llvm/llvm-project/pull/83487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
Endilll wrote:
My plan is to add tests to this PR, but if you want to land this sooner, I can
do tests in a separate PR.
https://github.com/llvm/llvm-project/pull/83487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
erichkeane wrote:
> The changes look correct to me, but I think we should add a DR test for this
> so that we can properly regenerate cxx_dr_status.html
>
> Also, the changes should come with a release note.
Ooof, yeah, forgot the release note. @Endilll has volunteered to do the DR
test in a
https://github.com/AaronBallman commented:
The changes look correct to me, but I think we should add a DR test for this so
that we can properly regenerate cxx_dr_status.html
Also, the changes should come with a release note.
https://github.com/llvm/llvm-project/pull/83487
_
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erich Keane (erichkeane)
Changes
The first sentence says:
If a template-parameter of a class template, variable template, or alias
template has a default template-argument, each subsequent template-parameter
shall either have a default t
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/83487
The first sentence says:
If a template-parameter of a class template, variable template, or alias
template has a default template-argument, each subsequent template-parameter
shall either have a default temp
