[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane resolved https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/65993: >From 52bcb5537fe67cdb93d50c16de181d87a7bcffc5 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 11 Sep 2023 11:28:04 -0700 Subject: [PATCH 1/4] Fix out of line Concept-comparisons of

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

@@ -218,6 +218,9 @@ Bug Fixes in This Version (`#65156 `_`) - Clang no longer considers the loss of ``__unaligned`` qualifier from objects as an invalid conversion during method function overload resolution. +- Clang now

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/cor3ntin approved this pull request. You obviously have a better grasp of that part of the code than I do, but the patch looks sensible to me. Thanks! https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

erichkeane wrote: Alright, I think I got it this time, we'll see how the buildbots treat it, but it passes locally for me. https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/65993: >From 52bcb5537fe67cdb93d50c16de181d87a7bcffc5 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 11 Sep 2023 11:28:04 -0700 Subject: [PATCH 1/3] Fix out of line Concept-comparisons of

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList ) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier(); -

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList ) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier(); -

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

erichkeane wrote: So the latest patch doesn't FIX it, it has a problem with: ``` template concept Concept = true; template struct S { struct Inner0 { struct Inner1 { template static constexpr int method(); }; }; }; template<> template constexpr int S<1>::Inner0::Inner1::method() { return

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList ) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier(); -

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/65993: >From 52bcb5537fe67cdb93d50c16de181d87a7bcffc5 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 11 Sep 2023 11:28:04 -0700 Subject: [PATCH 1/2] Fix out of line Concept-comparisons of

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

erichkeane wrote: Huh, blarg, build-bot found an issue with my patch, curiously in the same file I was editing! I'll look into it. I at least reproduce it, which is nice... https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList ) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier(); -

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList ) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier(); -

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

llvmbot wrote: @llvm/pr-subscribers-clang Changes As reported in GH65810, we don't properly collect ALL of the template parameters in a nested name specifier, and were only doing the 'inner level'. This patch makes sure we collect from all levels. Fixes: #65810 -- Full diff:

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane review_requested https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane review_requested https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane review_requested https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/65993: As reported in GH65810, we don't properly collect ALL of the template parameters in a nested name specifier, and were only doing the 'inner level'. This patch makes sure we collect from all levels. Fixes: