mikaelholmen wrote:
> @zahiraam I still get
>
> ```
> ../../clang/unittests/AST/DeclPrinterTest.cpp:1394:3: error: expression
> result unused [-Werror,-Wunused-value]
> [](PrintingPolicy &Policy) { Policy.SuppressTagKeyword = false; };
> ^
mikaelholmen wrote:
@zahiraam I still get
```
../../clang/unittests/AST/DeclPrinterTest.cpp:1394:3: error: expression result
unused [-Werror,-Wunused-value]
[](PrintingPolicy &Policy) { Policy.SuppressTagKeyword = false; };
^
..
zahiraam wrote:
oh! I think I know what the issue is. I have a fix for it. PR following up.
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
amy-kwan wrote:
This also fails on PPC, as well:
https://lab.llvm.org/buildbot/#/builders/36/builds/43998/steps/12/logs/stdio
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
kazutakahirata wrote:
Looking at other examples, should the lambda expression be the last argument to
`ASSERT_TRUE`?
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
kazutakahirata wrote:
> Creating a PR with `[](PrintingPolicy [[maybe_unused]] & Policy) {
> Policy.SuppressTagKeyword = true; };` on those tests.
I get this error while running `ninja check-clang-unit`. My build tree is
configured with `-DCMAKE_CXX_COMPILER=/usr/bin/clang++` and
`-DLLVM_ENA
zahiraam wrote:
Creating a PR with
`[](PrintingPolicy [[maybe_unused]] & Policy) {
Policy.SuppressTagKeyword = true;
};`
on those tests.
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
zahiraam wrote:
> I'm getting errors like:
>
> ```
> llvm-project/clang/unittests/AST/DeclPrinterTest.cpp:1394:3: error:
> expression result unused [-Werror,-Wunused-value]
> [](PrintingPolicy &Policy) { Policy.SuppressTagKeyword = false; };
> ```
>
> This file being a clang test, I am wonde
kazutakahirata wrote:
I'm getting errors like:
```
llvm-project/clang/unittests/AST/DeclPrinterTest.cpp:1394:3: error: expression
result unused [-Werror,-Wunused-value]
[](PrintingPolicy &Policy) { Policy.SuppressTagKeyword = false; };
```
This file being a clang test, I am wondering if this
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@AaronBallman Thanks!
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
Good catch, LGTM!
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2303,11 +2303,6 @@ printTo(raw_ostream &OS, ArrayRef Args, const
PrintingPolicy &Policy,
} else {
if (!FirstArg)
OS << Comma;
- if (!Policy.SuppressTagKeyword &&
- Argument.getKind() == TemplateArgument::Type &&
- isa(Argument.getAs
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Zahira Ammarguellat (zahiraam)
Changes
Fixed the printing of templated argument list and added test case.
---
Full diff: https://github.com/llvm/llvm-project/pull/86339.diff
2 Files Affected:
- (modified) clang/lib/AST/TypePrinter.cpp (
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/86339
>From ab7d280abf053b67b716e0723e2e70876e639810 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 22 Mar 2024 13:55:44 -0700
Subject: [PATCH 1/2] Fix printing of templated records.
---
clang/lib/AST
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3b3de48fd84b8269d5f45ee0a9dc6b7448368424
ab7d280abf053b67b716e0723e2e70876e639810 --
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/86339
None
>From ab7d280abf053b67b716e0723e2e70876e639810 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 22 Mar 2024 13:55:44 -0700
Subject: [PATCH] Fix printing of templated records.
---
clang/lib/A
22 matches
Mail list logo
