https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/70877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM assuming precommit CI is now fixed.
https://github.com/llvm/llvm-project/pull/70877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/70877
>From e24ee9cbc51d0f372c30512ce5722b2bc32e20d0 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Tue, 31 Oct 2023 16:45:17 -0700
Subject: [PATCH 1/2] Fix attribute plugins
---
clang/lib/Sema/ParsedAttr.cpp | 15
amykhuang wrote:
Whoops, sorry about that, I guess I am failing to update my fork properly...
https://github.com/llvm/llvm-project/pull/70877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Endilll wrote:
> https://github.com/amykhuang/llvm-project/tree/attr-plugin
> This branch is [2 commits
> ahead](https://github.com/amykhuang/llvm-project/compare/llvm:llvm-project:main...attr-plugin),
> [1684 commits
>
Endilll wrote:
This was fixed by e11148fda6d8c0eec496463adb46fd6f03a91081
I checked the logs, and exactly the part that this commit fixed is failing.
https://github.com/llvm/llvm-project/pull/70877
___
cfe-commits mailing list
AaronBallman wrote:
Oh wow, same failure a second time...
Ohh, this looks familiar now, but... it was already fixed, so why are we still
hitting this failure?
```
| expected: clang::TreeTransform<(anonymous
namespace)::CurrentInstantiationRebuilder>::RebuildArrayType(clang::QualType,
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/70877
>From 8216d6bc5329d4fcb723db14e2c503cb718cb36d Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Tue, 31 Oct 2023 16:45:17 -0700
Subject: [PATCH 1/2] Fix attribute plugins
---
clang/lib/Sema/ParsedAttr.cpp | 15
ldionne wrote:
This is weird, it's the first time I see this and I couldn't find any obvious
offending commit. It looks like it shouldn't be related, but at the same time
we're not seeing this issue in any of the other builds in the Clang pipeline.
You could consider updating the PR with the
https://github.com/AaronBallman approved this pull request.
> ping for review?
My apologies for the delay!
The changes LGTM but there is a precommit CI failure with libc++. As best I can
tell, that looks to be a transient issue and not caused by your patch, but it
would be good to verify
amykhuang wrote:
ping for review?
https://github.com/llvm/llvm-project/pull/70877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/70877
>From 18369263a3160963b943cd8574edaa212b6d0996 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Tue, 31 Oct 2023 16:45:17 -0700
Subject: [PATCH 1/2] Fix attribute plugins
---
clang/lib/Sema/ParsedAttr.cpp | 15
amykhuang wrote:
Updated the PR description and the patch. The existing
`clang/test/Frontend/plugin-attribute.cpp` seems sufficient for test coverage.
(I guess it wasn't being tested on bots though, otherwise we would have seen
it?)
https://github.com/llvm/llvm-project/pull/70877
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/70877
>From 18369263a3160963b943cd8574edaa212b6d0996 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Tue, 31 Oct 2023 16:45:17 -0700
Subject: [PATCH] Fix attribute plugins
---
clang/lib/Sema/ParsedAttr.cpp | 15
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/70877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amykhuang wrote:
Huh, apparently my no-unique-address patch did break existing plugin tests
(e.g. clang/test/Frontend/plugin-attribute.cpp), and this patch doesn't fix it
https://github.com/llvm/llvm-project/pull/70877
___
cfe-commits mailing list
https://github.com/AaronBallman commented:
As far as the changes go, they look correct to me. Thank you for the fix! Can
you try adding test coverage for the change?
https://github.com/llvm/llvm-project/pull/70877
___
cfe-commits mailing list
AaronBallman wrote:
> Can you please add a more detailed description of the problem and what the
> fix actually is. The description is what ends up in the git log and it is
> important that we have enough details there to understand the PR and what
> changes it makes.
>
> I do not see a
shafik wrote:
Can you please add a more detailed description of the problem and what the fix
actually is. The description is what ends up in the git log and it is important
that we have enough details there to understand the PR and what changes it
makes.
I do not see a test, can this fix be
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 604eff60abfce09f956c3b0b1414f8d0d04b5d47
bb896fbc4b7303bc0ef524bbff91e95610cb11ce --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Amy Huang (amykhuang)
Changes
[0faee97](https://github.com/llvm/llvm-project/commit/0faee97a924adec76d5c7cd680c289ced51e6b5a)
made the attribute plugin code hit an unreachable.
Bug:
https://github.com/amykhuang created
https://github.com/llvm/llvm-project/pull/70877
[0faee97](https://github.com/llvm/llvm-project/commit/0faee97a924adec76d5c7cd680c289ced51e6b5a)
made the attribute plugin code hit an unreachable.
Bug:
22 matches
Mail list logo
